[#17727] - Fixes for PHP 7.2 not allowing session config changes after headers sent
- Fixed in Code Base
- 30 Aug 2017
- Medium
- Build: staging
- # 17727
- Diff
- mbabker:7.2-session-fixes
User tests: Successful: Unsuccessful:
Summary of Changes
In PHP 7.2 the core engine is stricter about changing session related parameters after certain event happen. Generally, you would only run into these issues with the Joomla code in our testing environment because we're instantiating the session object (and inherently the API internals) quite a few times.
To prevent the error, PHP config changes should check if the headers have been sent first, which is what this PR does.
Testing Instructions
On all supported environments, Joomla continues to work as normal and you don't get new session related issues. The number of errors on the Travis-CI builds for PHP 7.2 and later is reduced from 9 to 1.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Nope.
This is largely ok. But I think some of these test failures are due to us not using the mock session correctly. Tests like JApplicationBaseTest::testLoadIdentity and JOAuth1ClientTest::testAuthenticate can probably just be fixed by using JSessionHandlerArray (https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/joomla/session/handler/array.php) rather than using the JSessionHandlerJoomla
It would definitely help to use the mocks. But, the fixes would be required too if the session API were correctly tested. We had the same types of failures on the Framework package and these changes fixed the issue there.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-30 23:47:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
is this PR related to an open Issue?