[#17718] - wrong language string on installation #17706
- Fixed in Code Base
- 27 Aug 2017
- Medium
- Build: staging
- # 17718
- Diff
- 810:patch4
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Corrects #17706
Test instructions
Dowload last staging.
Modify the en-GB.ini as this PR does.
Install using en-GB and click on Remove "Installaion" Folder
Steps to reproduce the issue
Install, and press Remove "installation" folder
Expected result
"installation" folder removed.
Actual result
"installation" folder removed.
After Patch
"installation" folder removed.
System information (as much as possible)
install with en-gb language
Additional comments
| Category | ⇒ | Installation Language & Strings |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17718.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Can be merged on review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17718.
Wile this PR works isnt the real problem to resolve the why html entities are not being rendered here
It's an AJAX driven task so something with the JavaScript handling it I would presume.
@mbabker
Counting @brianteeman as testing OK, can this be merged?
It would avoid TTs already working on these ini files to make an error.
Explanation
The value of the button can only be assigned text and not HTML
and current language string value is HTML and not text !
"installation"and by doing
$el.val(r.data.text);javascript will correctly encode the given value before assigning into the value
to make it more clear
imagine that your language string had not only HTML character entities but also HTML tags,
would you expect that an input-type-button would interpret and show the following HTML ?
<b> "Text" </b> and some more \"text\"try the below small HTML example to see what is happening
<html>
<script>
document.addEventListener("DOMContentLoaded", function() {
var some_html = "<b> "Text" </b> and some more \"text\" ";
// The assigned string will be encoded because .value is text property
document.getElementById('input-test').value = "<b> "Text" </b> and some more \"text\" ";
// The assigned string will not be encoded because .innerHTML can be assigned HTML
document.getElementById('div-test').innerHTML = "<b> "Text" </b> and some more \"text\" ";
});
</script>
<body>
<input id="input-test" type="button" value="This is a text value, i can not display HTML tags or interpret HTML entities , etc">
<div id="div-test">HTML can be placed here</div>
</body>
</html>
In short to continue my above answer it was not good idea to assign response to the value of the input-typebutton
Correct fix , now and for future
- after click hide the button and display a div with a loading animation
- and on response received set the response's HTML as innerHTML of the above div
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-27 16:09:07 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
In any case, as we will not have any "_QQ_" in 4.0, I think it is best to always use escaped double quotes everywhere we need double quotes now and get rid of ". This will normalise the work for TTs, once they are explained this.
com_localise, already since a few versions, is already doing this systematically.
Using " is fine if you can guarantee the string will always be displayed in an HTML context. Using escaped quotes is better since you don't have to worry about the display context.
That is exactly what I meant. It will work in any context.
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.