?
avatar 810
810
24 Aug 2017

Steps to reproduce the issue

Install, and press Remove "installation" folder

Expected result

"installation" folder removed.

Actual result

"installation" folder removed.

System information (as much as possible)

install with en-gb language

Additional comments

avatar 810 810 - open - 24 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Aug 2017
avatar brianteeman
brianteeman - comment - 24 Aug 2017

What version of Joomla?

avatar 810
810 - comment - 24 Aug 2017

staging

avatar brianteeman
brianteeman - comment - 24 Aug 2017

I didnt get that

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Aug 2017
Category com_installer
avatar 810
810 - comment - 24 Aug 2017

ezgif-2-3d1923d8bc

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Aug 2017
Status New Discussion
avatar Quy
Quy - comment - 24 Aug 2017

Unable to reproduce with staging. I didn't have to click Remove "installation" folder button twice like you did in your screencast.

avatar 810
810 - comment - 24 Aug 2017

tested again: Some result
New sub domain, downloaded staging again.

wamp 64x - chrome 60.0.3112.101

avatar 810
810 - comment - 24 Aug 2017

With IE i see no quotes, its working correct.

IE = failed = "installation" folder removed.
Firefox = failed = "installation" folder removed.
Chrome = failed = "installation" folder removed.

avatar Quy
Quy - comment - 24 Aug 2017

Still unable to reproduce using Chrome v60.0.3112.113 in XAMPP on Windows 10.

avatar 810
810 - comment - 24 Aug 2017

Please check that you select : English (United Kingdom)
i also made the mistake to select English us. Now all browsers are failing.

avatar Quy
Quy - comment - 24 Aug 2017

OK I can confirm the issue with English US.

avatar 810
810 - comment - 24 Aug 2017

Uk you mean?
English US = working for me

avatar Quy
Quy - comment - 24 Aug 2017

Sorry, UK is not working. US is working only because it has not been updated per this PR #17436 .

avatar infograf768
infograf768 - comment - 25 Aug 2017

These strings should be modified to use escaped double quotes, or use single quotes

INSTL_COMPLETE_ERROR_FOLDER_DELETE="\"%s\" folder could not be deleted. Please manually delete the folder."
INSTL_COMPLETE_FOLDER_REMOVED="\"%s\" folder removed."

or

INSTL_COMPLETE_ERROR_FOLDER_DELETE="'%s' folder could not be deleted. Please manually delete the folder."
INSTL_COMPLETE_FOLDER_REMOVED="'%s' folder removed."

to get correctly
screen shot 2017-08-25 at 08 52 29

avatar infograf768
infograf768 - comment - 25 Aug 2017

Another solution is to modify .../installation/controller/removefolder.php line 117-125 to use
htmlspecialchars_decode

// If an error was encountered return an error.
		if (!$return)
		{
			$app->sendJsonResponse(new Exception(htmlspecialchars_decode(JText::sprintf('INSTL_COMPLETE_ERROR_FOLDER_DELETE', 'installation')), 500));
		}

		// Create a response body.
		$r = new stdClass;
		$r->text = htmlspecialchars_decode(JText::sprintf('INSTL_COMPLETE_FOLDER_REMOVED', 'installation'));

@mbabker @Bakual
What do you prefer?

avatar Bakual
Bakual - comment - 25 Aug 2017

I would just use single quotes or escaped quotes.

avatar 810 810 - change - 25 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-25 14:33:57
Closed_By 810
avatar 810 810 - close - 25 Aug 2017
avatar 810
810 - comment - 25 Aug 2017

i made a pr for it, so I'm closing this issue

avatar infograf768
infograf768 - comment - 25 Aug 2017

PR is here #17718

Add a Comment

Login with GitHub to post a comment