? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
24 Aug 2017

Pull Request for Issue #17698

Summary of Changes

This PR fixes the top margin that should be assigned to any <div> that comes after the header. The issue before was the scope of the CSS.

Testing Instructions

  • Disable the banner and all modules assigned to the top-a and top-b positions.

There should be a space between the header and next element.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2017
Category Front End Templates (site)
avatar C-Lodder C-Lodder - open - 24 Aug 2017
avatar C-Lodder C-Lodder - change - 24 Aug 2017
Status New Pending
avatar C-Lodder C-Lodder - change - 24 Aug 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 24 Aug 2017

Ignore the Windows lines endings in the CSS file.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Aug 2017

I have tested this item successfully on 3689e4b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17699.

avatar eXsiLe95 eXsiLe95 - test_item - 24 Aug 2017 - Tested successfully
avatar eXsiLe95
eXsiLe95 - comment - 24 Aug 2017

I have tested this item successfully on 3689e4b

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17699.

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Aug 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 25 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-25 12:44:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Aug 2017
avatar wilsonge wilsonge - merge - 25 Aug 2017

Add a Comment

Login with GitHub to post a comment