[#17689] - Tagged items: add microdata
- Fixed in Code Base
- 26 Feb 2018
- Medium
- Build: staging
- # 17689
- Diff
- LivioCavallo:tagged-items.microdata
User tests: Successful: 0 Unsuccessful: 0
Summary of Changes
Added ItemList microdata (name, image, description, ...) to default_items tag view.
Testing Instructions
In J! 3.7.5
Tag some items (articles, contacts) with tag "Joomla".
Create a menuitem of type "Tagged Items", tag "Joomla".
Expected result
Like in article, blog, ... page types, we expect that Microdata should be present for listed items in "Tagged Items" page.
Actual result
Microdata is not present.
(verify at: https://search.google.com/structured-data/testing-tool that ItemListis not present)
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | New | ⇒ | Pending |
we should use
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Microdata/Microdata.php
i guess ?
May be, but blogs and articles insert plain intempscope, intemprop in elements. I followed.
@alikon as per the comment #8934 (comment) and the comment at #8933 (comment) which were decisions resulting from the discussion in PR #3358, from all of those the decision has been that we use hard coded values for microdata.
thanks for the recap
Please, @alikon and @photodude , could you test this?
@LivioCavallo I apologize, but at the moment I don't have time for testing. If/when I get some reasonable time set aside I'll be working on the automatic code standards fixers I would really like to see it get to a stable release before the end of the year.
I have tested this item
With this patch "Tagged Items" sites have the ItemList item and can be found by the Google tool.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17689.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
@LivioCavallo Please resolve conflicting File.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I hope I followed the right procedure to resolve conflicting files (I suspect I made too many merges...). Sorry for this.
@LivioCavallo looks good
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-26 03:21:47 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on cad677c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17689.