User tests: Successful: 2 Murat75, eXsiLe95 Unsuccessful: 0
Moves the encryption libraries to the Joomla Namespace and removes FOF. Note as I've changed the functions to use native PHP functions rather than also porting FOFUtilsPhpfunc
I've deliberately not classmapped the FOF classnames as there are b/c breaks
Check 2FA works before and after PR
Category | ⇒ | Administration com_admin com_users Repository SQL Installation Postgresql Language & Strings Libraries External Library |
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Title |
|
how can that be marked a successful test when it identifies numerous bugs?
@brianteeman The exclution of FOF works perfectly fine - it's another bug that encountered before. This should be another issue, I guess, since it has nothing to do with the topic or goal of this issue directly. Also, the testing procedure of this issue (exclution of FOF) is very huge, testing for this little bug is much easier in another issue with fewer steps.
@wilsonge It could also be fixed here! But then I have to check the whole procedure again in the name of issue tracking ;)
I see you've updated your references. Does this mean it is or isn't working in entirety now?
@wilsonge We just tested this on a clean 4.0-dev checkout. If you have 2FA enabled and want to login with a user that does not have 2FA enabled you cannot login on backend. You get this:
So this is an issue not related to your PR but a pre-existing issue.
Your PR works as expected.
ah i see what yu mean abut the aria-required
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-24 13:19:22 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
I have tested this item
I have tested this item
System Information
Running on XAMPP 7.1.4-0
macOS Sierra Version 10.12.6
Safari Version 10.1.2
PHP 7
Joomla! 4.0-dev (joomla@4.0.0)
Steps
Install XAMP 7.1.4-0 on macOS
Install joomla from github with the branch 4.0-dev
Clone this on your Mac with your Download an ZIP-File and put it on the htdocs
XAMPP on mac is difficult with the user rights, you must be give on terminal the folder admin rights with "chmod 777" to continue install joomla-4
Install Joomla4
You must activate the Two Factor Authentication
create user
Go to frontend/site /index.php
Test without TFA
Test with Google TFA
Test with YubiKey
Go to backend/administrator <yourinstallpath/administrator
Test without TFA
Test with Google TFA
Test with YubiKey TFA
Now I install the joomla from Wilson with is fixedwrong PR and started the test again.
Test without TFA
Test with Google TFA
Test with YubiKey
Tested @icampus
I have tested this item✅ successfully on cf63da3
Testing
System Information
Patch Tester 3.0.0 Beta 3Steps
<yourinstallpath>/index.php
<youtinstallpath>/index.php/login
<youtinstallpath>/index.php/login
<youtinstallpath>/index.php/login
<yourinstallpath/administrator
Expected result
Login attempts with wrong information will fail and throw an error accordingly. Login attempts with correct login data will be successfull. Installation of R/C should not affect this behavior.
Result before PR
required aria-required="true"
fixed the issue)required aria-required="true"
fixed the issue)Result with PR
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
but login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
required aria-required="true"
fixed the issue)required aria-required="true"
fixed the issue)Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Bug!Works as expectedThe requested page can't be found.
and login was unsuccessfull. Error:Class 'Joomla\CMS\Encrypt\Aes' not found
Testing results (in a nutshell)
The directoryJoomla\CMS\Encrypt\Aes
, located in<yourinstallpath>\libraries\src\
does not exist. It is only available in the old folder of FOF.Using the PatchInstaller 3.0.0, the files were not changed correctly. I now used an installation in which the PR was applied using the DIFF-URL and git apply
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17687.