[#17668] - redo of flo's tag branch and merge
- Fixed in Code Base
- 23 Aug 2017
- Medium
- Build: staging
- # 17668
- Diff
- JannikMichel:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #5474 .
Summary of Changes
I try to finish the great work from @jrseliga and @florian1995.
@florian1995 fixed the problem that when you deselect for example all tags the list won't refresh.
The following test instructions are also from @jrseliga.
Testing Instructions
Administrator
Articles
- Create 3 articles:
- Article 1 - Category 1 - Tag 1 - Author 1 - Public
- Article 2 - Category 2 - Tag 1 & Tag 2 - Author 2 - Registered
- Article 3 - Category 2 - Tag 2 - Author 1 - Super User
- View Articles
- Use Search Tools
Just with a simple structure like this, there is a large number of potential test cases. Please refer to the New behavior section for an overview of the filtering logic
Featured Articles
- View Featured Articles
Use Search Tools
Categories
- View Categories
-Use Search Tools
Developed@icampus
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_modules com_newsfeeds Language & Strings Front End Modules |
| Status | New | ⇒ | Pending |
I have tested this item
Tested:
Testing
- Created multiple articles (like described)
- Went to article overview
- Used article filters
Before patch
Only one option per filter can be selected. Multiple filters are useable, but not multiple options on one filter.
With patch
Multiple options on a single filter can be selected. Works as described and expected.
Suggestions
You can not see what field matches a filter. Therefore, the initial value could be displayed instead of dummy text "Type or select some options". Maybe, you should use CSS placeholder instead of HTML value, too.
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17668.
| Labels |
Added:
?
?
|
||
I have tested this item
## Tested:
Testing
- Created multiple articles (like described)
- Went to article overview
- Used article filters
Before patch
Only one option per filter can be selected. Multiple filters are useable, but not multiple options on one filter.
With patch
Multiple options on a single filter can be selected. Works as described and expected.
Notes
Since the update, every field has its own placeholder. Good job!
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17668.
I have tested this item
Operating System
- Joomla! 3.8.0-beta3-dev
- PHP 5.6.2
- MySQLi 5.5.38
- Apache/2.2.29 (Unix)
Steps
- Open article administration
- Use search tools
Test before patch
- Single filter selection
Test after patch
- Multi filter selection for category, access, author tag
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17668.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-23 11:55:54 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
This has broken multilang frontend!
Not only multilang. any menu item displaying a category does not display any article.
There are no articles in this category. If subcategories display on this page, they may contain articles.
I have tested this item✅ successfully on cedb5ee
@icampus
Everything works how it should be.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17668.