Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
18 Aug 2013

This pull request fixes a long standing Joomla! 2.5 issue which prevents any updates (core Joomla! and its extensions) from working on servers where URL fopen() wrappers are disabled. Moreover it fixes a related issue with installing extensions from URL on such servers.

The changes made are:

  • Backport of JHttpFactory from Joomla! 3
  • Modification of JUpdater and related classes to use JHttpFactory
  • Removal of evil eval() code in JUpdater and related classes which caused the updater to not work at all on shared hosts which correctly and justifiably disallow the use of eval() for security reasons
  • Modification of JInstallerHelper::downloadPackage to use JHttpFactory

This Pull Request does not have any backwards compatibility issues.

avatar nikosdion nikosdion - open - 18 Aug 2013
avatar piotr-cz
piotr-cz - comment - 19 Aug 2013

When using JHttp, you catch it's exceptions (ie. when update server is down), otherwise the update server may be permanently locked out from next update checks.

See #1278

avatar nikosdion
nikosdion - comment - 19 Aug 2013

Thanks @piotr-cz I have backported your Joomla! 3 bugfix in my PR.

Add a Comment

Login with GitHub to post a comment