Feeling Lucky
[#1765] - Regarding issue tracker #29442 - Backport cURL support and related updater and installer fixes
- Closed
- 22 Aug 2013
- Medium
- Build: 2.5.x
- # 1765
- Diff
- nikosdion:29442-backport-curl-support
User tests: Successful: Unsuccessful:
This pull request fixes a long standing Joomla! 2.5 issue which prevents any updates (core Joomla! and its extensions) from working on servers where URL fopen() wrappers are disabled. Moreover it fixes a related issue with installing extensions from URL on such servers.
The changes made are:
- Backport of JHttpFactory from Joomla! 3
- Modification of JUpdater and related classes to use JHttpFactory
- Removal of evil eval() code in JUpdater and related classes which caused the updater to not work at all on shared hosts which correctly and justifiably disallow the use of eval() for security reasons
- Modification of JInstallerHelper::downloadPackage to use JHttpFactory
This Pull Request does not have any backwards compatibility issues.
When using JHttp, you catch it's exceptions (ie. when update server is down), otherwise the update server may be permanently locked out from next update checks.
See #1278