? ? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
20 Aug 2017

Summary of Changes

Runs composer update against the 4.0 branch.

Package operations: 0 installs, 33 updates, 0 removals
  - Updating paragonie/sodium_compat (v1.0.1 => v1.1.0): Downloading (100%)         
  - Updating symfony/polyfill-util (v1.4.0 => v1.5.0): Downloading (100%)         
  - Updating symfony/polyfill-php56 (v1.4.0 => v1.5.0): Downloading (100%)         
  - Updating symfony/web-link (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating symfony/yaml (v3.3.2 => v3.3.6): Loading from cache
  - Updating symfony/stopwatch (v3.3.2 => v3.3.6): Loading from cache
  - Updating symfony/process (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating symfony/finder (v3.3.2 => v3.3.6): Loading from cache
  - Updating symfony/filesystem (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating symfony/event-dispatcher (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating symfony/polyfill-mbstring (v1.4.0 => v1.5.0): Loading from cache
  - Updating symfony/debug (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating symfony/console (v3.3.2 => v3.3.6): Downloading (100%)         
  - Updating friendsofphp/php-cs-fixer (v1.13.1 => v1.13.2): Downloading (100%)         
  - Updating zendframework/zend-diactoros (1.4.0 => 1.4.1): Loading from cache
  - Updating phpdocumentor/type-resolver (0.2.1 => 0.3.0): Loading from cache
  - Updating phpdocumentor/reflection-docblock (3.1.1 => 3.2.2): Loading from cache
  - Removing joomla/string (dev-2.0-dev 7515dfa)
  - Installing joomla/string (dev-2.0-dev fb39e97): Downloading (100%)         
  - Removing joomla/utilities (dev-2.0-dev 05c3784)
  - Installing joomla/utilities (dev-2.0-dev c56004c): Downloading (100%)         
  - Removing joomla/registry (dev-2.0-dev 92bb9c5)
  - Installing joomla/registry (dev-2.0-dev 1f23fc8): Downloading (100%)         
  - Removing joomla/application (dev-2.0-dev 61c9b00)
  - Installing joomla/application (dev-2.0-dev 3cc2e7b): Downloading (100%)         
  - Removing joomla/controller (dev-2.0-dev 02fde4b)
  - Installing joomla/controller (dev-2.0-dev f260d32): Downloading (100%)         
  - Removing joomla/crypt (dev-master 88dcee0)
  - Installing joomla/crypt (dev-master 90ccaa4): Downloading (100%)         
  - Removing joomla/data (dev-2.0-dev 6131c68)
  - Installing joomla/data (dev-2.0-dev 5e7110d): Downloading (100%)         
  - Removing joomla/event (dev-2.0-dev 1bde2bb)
  - Installing joomla/event (dev-2.0-dev 5b07077): Downloading (100%)         
  - Removing joomla/database (dev-2.0-dev 82250d1)
  - Installing joomla/database (dev-2.0-dev 6b3e3c1): Downloading (100%)         
  - Removing joomla/di (dev-2.0-dev db55532)
  - Installing joomla/di (dev-2.0-dev 6b99464): Downloading (100%)         
  - Removing joomla/uri (dev-2.0-dev 0bb88f2)
  - Installing joomla/uri (dev-2.0-dev afc1b67): Downloading (100%)         
  - Removing joomla/http (dev-2.0-dev 23f95a0)
  - Installing joomla/http (dev-2.0-dev 3feedaa): Downloading (100%)         
  - Removing joomla/image (dev-2.0-dev f49a7f4)
  - Installing joomla/image (dev-2.0-dev b62da9a): Downloading (100%)         
  - Removing joomla/session (dev-2.0-dev c5b16c1)
  - Installing joomla/session (dev-2.0-dev a4de456): Downloading (100%)         
  - Removing joomla/oauth1 (dev-2.0-dev 7855fee)
  - Installing joomla/oauth1 (dev-2.0-dev ec73eee): Downloading (100%)         
  - Removing joomla/oauth2 (dev-2.0-dev 85837a6)
  - Installing joomla/oauth2 (dev-2.0-dev 6468155): Downloading (100%)         

Also switches the joomla/archive and joomla/ldap packages to the Framework 2.0 branches.

Because of updates the joomla/compat package is no longer required and removed from the tree.

With the switch to the PHP 7 minimum, the APC and Memcache session handlers are removed (APC was phased out at PHP 5.5 and replaced with OPCache in core and APCu as an addon; the Memcache extension is dead and not updated for PHP 7 anyway).

Testing Instructions

The CMS still runs.

Documentation Changes Required

Note in 4.0 the dropped support for noted session handlers.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2017
Category External Library Composer Change Libraries
avatar mbabker mbabker - open - 20 Aug 2017
avatar mbabker mbabker - change - 20 Aug 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2017
Category External Library Composer Change Libraries Unit Tests Repository External Library Composer Change Libraries
avatar mbabker mbabker - change - 20 Aug 2017
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 21 Aug 2017

Unsure if we want to drop compat - didn't we have problems with JsonSerializable on non-PHP 5.3 envs (hence our comment at https://github.com/joomla-framework/compat/blob/master/src/JsonSerializable.php#L11)

avatar mbabker
mbabker - comment - 21 Aug 2017

Then it needs to be a CMS dependency. It's not in the root composer.json so whatever transient dependency included it is no longer there.

avatar wilsonge
wilsonge - comment - 21 Aug 2017

Yah. I guess we screwed up when we very first did composer 02bdc26

avatar mbabker
mbabker - comment - 21 Aug 2017

If we still need to do that, I'd just inline the file back into the CMS. At this point the whole Compat package is a dead thing.

avatar wilsonge
wilsonge - comment - 21 Aug 2017

OK So the question is on how many hosts will this not exist. So Debian which was our issue has Stretch which ships with PHP 7 - so depending on if they've resolved their license issue we can make a decision on whether it's required or not

If we are removing this package then we at least need to update these sorts of imports https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/import.php#L55-L59

avatar laoneo
laoneo - comment - 22 Aug 2017

I would do the update when #16896 got merged into the 4 branch.

avatar mbabker mbabker - change - 27 Sep 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-09-27 23:07:03
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Sep 2017

Add a Comment

Login with GitHub to post a comment