Feeling Lucky
?
?
[#17642] - [4.0] Make JHtml::_() final and variadic
- Fixed in Code Base
- 21 Aug 2017
- Medium
- Build: 4.0-dev
- # 17642
- Diff
- mbabker:jhtml-loader
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
- We really shouldn't allow
JHtml::_()to be extended/overridden if someone subclassesJHtml, so this makes the method final. - Since the method is now final, we can typehint the
$keyargument with its scalar value. - Now that we can allow PHP 5.6 features, lets make the
JHtml::_()method signature variadic so it is now documented more efficiently that the method has more than one argument.
Testing Instructions
The CMS still works.
Documentation Changes Required
Note the B/C break in JHtml::_() being made final.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-21 03:12:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||