Feeling Lucky
?
[#17639] - fix the drone error Line exceeds 150 characters error
- Fixed in Code Base
- 20 Aug 2017
- Medium
- Build: 4.0-dev
- # 17639
- Diff
- zero-24:fix_drone
User tests: Successful: Unsuccessful:
Pull Request for Issue #17637
Summary of Changes
fix the drone error Line exceeds 150 characters error cc @wilsonge @C-Lodder
Testing Instructions
review
Expected result
no errors
Actual result
FILE: /drone/src/github.com/joomla/joomla-cms/plugins/system/debug/debug.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
647 | WARNING | Line exceeds 150 characters; contains 165 characters
--------------------------------------------------------------------------------
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
mbabker
- comment
- 20 Aug 2017
Sooner or later we really need to revisit this hard line length limit in the PHPCS rules. Far too often it results in "creative" concatenation to get around it which makes things painful to read.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-20 23:44:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 92d7b11
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17639.