? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Aug 2017

Pull Request for #16594

This is the code of @ced1870 as he doesnt appear to be submitting his own code as a PR

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2017
Category Front End com_contact
avatar brianteeman brianteeman - open - 20 Aug 2017
avatar brianteeman brianteeman - change - 20 Aug 2017
Status New Pending
avatar laoneo
laoneo - comment - 20 Aug 2017

Is this not a revert of #15968? Ping @matrikular.

avatar brianteeman
brianteeman - comment - 20 Aug 2017

I don't know? It's not !y code I am just trying to clean the teacker

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Aug 2017

Thanks for cleaning, @brianteeman

avatar matrikular
matrikular - comment - 20 Aug 2017

Thanks @laoneo
It seems that way, yes.

As far as I can tell by looking at the issue / proposed code, I will probably create another PR for it, as the solution to the "problem" (there are more*) is not that simple. Well, it is simple, but would require us to have a common understanding of how the fields should be rendered first.

*This PR removes the mandatory dt tag, we have obsolete whitespace in the class attribute when no class was given + in this case: custom fields in contact add a prefix to the class attribute.

avatar brianteeman
brianteeman - comment - 20 Aug 2017

OK i will close this then and await your PR @matrikular

avatar brianteeman brianteeman - change - 20 Aug 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-08-20 18:27:12
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 20 Aug 2017

Add a Comment

Login with GitHub to post a comment