? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Aug 2017

In the list of valid URL scheme used in Joomla and in the url field plugin is a type of "url"

This is not a valid url scheme - see https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

This PR removes it and also solves #14360 which was caused by this confusion

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2017
Category Administration com_menus Libraries Front End Plugins
avatar brianteeman brianteeman - open - 20 Aug 2017
avatar brianteeman brianteeman - change - 20 Aug 2017
Status New Pending
avatar brianteeman brianteeman - change - 20 Aug 2017
Labels Added: ?
512cf28 20 Aug 2017 avatar brianteeman space
avatar Quy Quy - test_item - 20 Aug 2017 - Tested successfully
avatar Quy
Quy - comment - 20 Aug 2017

I have tested this item successfully on 512cf28

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17631.

avatar CiverBlack CiverBlack - test_item - 21 Aug 2017 - Tested successfully
avatar CiverBlack
CiverBlack - comment - 21 Aug 2017

I have tested this item successfully on 512cf28

i reviewed the code and it seems to be correct now.

@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17631.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2017

RTC after two successful tests.

avatar brianteeman brianteeman - change - 21 Aug 2017
Labels Added: ?
avatar mbabker mbabker - change - 21 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-21 23:47:16
Closed_By mbabker
avatar mbabker mbabker - close - 21 Aug 2017
avatar mbabker mbabker - merge - 21 Aug 2017
avatar brianteeman
brianteeman - comment - 21 Aug 2017

Thanks

Add a Comment

Login with GitHub to post a comment