? ? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
19 Aug 2017

Pull Request for Issue #17582 .

Summary of Changes

Add m.language and l.image in the "GROUP BY" clause :
sql_group="a.id, m.language, l.image"

Testing Instructions

Login as administrator.
Click on Menus

Expected result

All menus are displayed as expected.

Actual result

All menus are displayed as expected.

Documentation Changes Required

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2017
Category Administration com_menus
avatar twister65 twister65 - open - 19 Aug 2017
avatar twister65 twister65 - change - 19 Aug 2017
Status New Pending
avatar infograf768
infograf768 - comment - 21 Aug 2017

@izharaazmi @alikon
Please test

avatar SamuelSchepp SamuelSchepp - test_item - 21 Aug 2017 - Tested successfully
avatar SamuelSchepp
SamuelSchepp - comment - 21 Aug 2017

I have tested this item successfully on 2a2fbd0

Teststack:
MAMP 4.2 on macOS 10.1.2
PostgreSQL 9.6.4 on Docker

Tested:

  • Log in as administrator
  • Menus -> Manage (Without patch, this action is not possible due to sql error)

Without patch:
Error page with title "Error: 0 ERROR: column "m.language" must appear in the GROUP BY clause or be used in an aggregate function LINE 1: ...E(SUM(m.home), 0) WHEN 0 THEN '' WHEN 1 THEN CASE m.language... ^"

With patch:
All menus are displayed as expected.

Tested @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17620.

avatar izharaazmi
izharaazmi - comment - 21 Aug 2017

Please also test the following condition:

Go to #__menu table and set two or more record in a menutype to home=1 manually. Then check if the globe icon is displayed in the admin menu for that menu type.

avatar twister65 twister65 - change - 21 Aug 2017
Labels Added: ?
avatar Kev1n337
Kev1n337 - comment - 21 Aug 2017

@izharaazmi Could you specify further what I need to do, to test your scenario? I manually set some lines to home=1, but I don't know where and when I should see that globe icon.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17620.

avatar twister65
twister65 - comment - 21 Aug 2017

I've set two records to home=1 in the #__menu table, and the globe icon is well displayed.
Just log in to administrator, and click on "Menus".

avatar twister65 twister65 - change - 21 Aug 2017
The description was changed
avatar twister65 twister65 - edited - 21 Aug 2017
avatar Kev1n337 Kev1n337 - test_item - 21 Aug 2017 - Tested successfully
avatar Kev1n337
Kev1n337 - comment - 21 Aug 2017

I have tested this item successfully on f3dc52a

When testing Joomla 3.7.5 with PostgreSQL, Administrator page displays noting but the error description: "Error page with title "Error: 0 ERROR: column "m.language" must appear in the GROUP BY clause or be used in an aggregate function LINE 1"
After applying the patch it worked as expected and all menus were displayed correctly.
@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17620.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2017

@SamuelSchepp can you please retest?

avatar SamuelSchepp SamuelSchepp - test_item - 21 Aug 2017 - Tested successfully
avatar SamuelSchepp
SamuelSchepp - comment - 21 Aug 2017

I have tested this item successfully on f3dc52a

Still works with patch as described earlier. @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17620.

avatar SamuelSchepp SamuelSchepp - test_item - 21 Aug 2017 - Not tested
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2017

RTC after two successful tests.

avatar SamuelSchepp SamuelSchepp - test_item - 21 Aug 2017 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2017
Category Administration com_menus Administration com_menus Modules Front End
avatar twister65 twister65 - change - 21 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2017
Category Administration com_menus Modules Front End Administration com_menus Language & Strings Modules Front End
avatar wojsmol
wojsmol - comment - 21 Aug 2017

@twister65 Last 2 commits are in wrong branch - this should by a separate PR.

avatar twister65 twister65 - change - 21 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2017
Category Administration com_menus Modules Front End Language & Strings Administration com_menus
avatar mbabker mbabker - change - 21 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-21 23:46:52
Closed_By mbabker
Labels Removed: ?
avatar mbabker mbabker - close - 21 Aug 2017
avatar mbabker mbabker - merge - 21 Aug 2017

Add a Comment

Login with GitHub to post a comment