? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
19 Aug 2017

Pull Request for Issue #16941.

Summary of Changes

Renames the namesapce and the existing MVC factory classe names to upper case MVC. Additionally it fixes an issue where the factory is not passed down the hierarchy from the models and controllers which do extend from the base model/controller.

The important change is that the MVC classes in the component needs to end with the type to be inline with the rest of the namespaced classes. See #17614 for more details. For example the Articles model which has now the name Joomla\Component\Administrator\Model\Articles will become then
Joomla\Component\Administrator\Model\ArticlesModel.

If this one gets merged, then I will adapt the extensions in the 4.0-dev branch accordingly.

Testing Instructions

  • Open the back end
  • Create an article

Expected result

All is working as expected.

Actual result

All is working as expected.

Documentation Changes Required

If there is already documentation written for the MVC factories, then it needs to be updated.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2017
Category Libraries
avatar laoneo laoneo - open - 19 Aug 2017
avatar laoneo laoneo - change - 19 Aug 2017
Status New Pending
avatar laoneo laoneo - change - 19 Aug 2017
Labels Added: ?
avatar mbabker
mbabker - comment - 20 Aug 2017

Needs to be synced up since I merged staging up to the 3.9 branch and also moved the MVC factory classes to the right directory.

00322c9 21 Aug 2017 avatar laoneo fgh
avatar laoneo
laoneo - comment - 21 Aug 2017

Merged.

b1549df 22 Aug 2017 avatar laoneo CS
avatar wilsonge
wilsonge - comment - 22 Aug 2017

You don't actually have the type in this PR. So this is just a renaming of the classes and stuff. But I'm good with that

avatar wilsonge wilsonge - change - 22 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-22 11:52:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Aug 2017
avatar wilsonge wilsonge - merge - 22 Aug 2017

Add a Comment

Login with GitHub to post a comment