? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
19 Aug 2017

Pull Request for Issue #17603.

Summary of Changes

Use appropriate parameter value to identify the effective asset name for com_categories and com_fields menu items.

Testing Instructions

  • Create a new user and add them to the Manager user group

  • Create a new admin menu
    Item 1: menu item type - menu heading
    Item 2: menu item type - list all articles, and set it have parent Item 1
    Item 3: menu item type - list all categories, component is articles, set it have parent Item 1
    Item 4: menu item type - list all categories, component is users, set it to have parent Item 1

  • Create a module for the menu and set the position to Menu and access to Special
    You should be able to now see this menu logged in as Super User with three items in it.

  • Log in as your new user (Manager).
    The admin menu you created will be shown but will only have one item in it - Item 1 (Item 1 is to ensure that the menu is shown.)

  • Do similar test for com_fields as well.

Expected result

User should be able to see category list menu items if they have the correct permissions, so a user who is a Manager should be able to see menu Item 1 and Item 2

Actual result

Can't see these menu items

Documentation Changes Required

None

avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2017
Category Modules Administration
avatar izharaazmi izharaazmi - open - 19 Aug 2017
avatar izharaazmi izharaazmi - change - 19 Aug 2017
Status New Pending
avatar heleneross
heleneross - comment - 19 Aug 2017

tested out your new code - categories and fields links now work as expected.
Control Panel is also missing both in the standard admin menu and custom admin menu.

avatar izharaazmi
izharaazmi - comment - 19 Aug 2017

Control panel is missing because Joomla is shipped with no access to com_cpanel. But the access is not checked within the component. Ideally it should ship with the permission to all by default. This can be discussed and accordingly fixed in another PR.

avatar infograf768 infograf768 - test_item - 22 Aug 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 22 Aug 2017

I have tested this item successfully on 8095d35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17613.

avatar infograf768
infograf768 - comment - 22 Aug 2017
avatar Heggi93 Heggi93 - test_item - 22 Aug 2017 - Tested successfully
avatar Heggi93
Heggi93 - comment - 22 Aug 2017

I have tested this item successfully on 8095d35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17613.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Aug 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 22 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-22 12:03:43
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 22 Aug 2017
avatar mbabker mbabker - merge - 22 Aug 2017

Add a Comment

Login with GitHub to post a comment