? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Aug 2017

PR for #13933

Really just to protect crazy settings

avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2017
Category Administration com_config
avatar brianteeman brianteeman - open - 18 Aug 2017
avatar brianteeman brianteeman - change - 18 Aug 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2017

I have tested this item successfully on 181f522


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17609.

avatar Schmidie64 Schmidie64 - test_item - 21 Aug 2017 - Tested successfully
avatar Schmidie64
Schmidie64 - comment - 21 Aug 2017

I have tested this item successfully on 181f522

@icampus
I've tested this PR sucessully. But maybe you should add a check to prevent high values in the config(see attachment)configuration.php ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17609.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2017

RTC after two successful tests.

avatar brianteeman
brianteeman - comment - 21 Aug 2017

We don't have any other checks for someone manually editing the file on the server with crazy values

avatar mbabker mbabker - change - 21 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-21 12:01:29
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 21 Aug 2017
avatar mbabker mbabker - merge - 21 Aug 2017
avatar brianteeman
brianteeman - comment - 21 Aug 2017

Thanks so for testing and merging

avatar tonypartridge
tonypartridge - comment - 22 Aug 2017

Thanks for doing @brianteeman!

Add a Comment

Login with GitHub to post a comment