[#17602] - Contact modified to be validable and accessible
- Fixed in Code Base
- 22 Aug 2017
- Medium
- Build: staging
- # 17602
- Diff
- LivioCavallo:content.validable-accessible
User tests: Successful: Unsuccessful:
Summary of Changes
Added missing < label > to < select > element, for accessibility.
Replaced align attribute on < img > element with css styling (vertical-align : middle).
Added missing < dt > child element inside < dl > element
Testing Instructions
Joomla! 3.7.4
Create 2 Contacts and populate Image and Position fields (in default category).
Create a menuitem of type "list Contacts in a category" (default category) and in "Contact Display options" set "Show Contact List" ("Contact Position" and "Image" are set to "show" already).
Browse to that page and select one of the contacts, so a contacts selector is shown.
Expected result
Validating HTML (https://validator.w3.org/) and accessibility check (https://achecker.ca/checker/index.php) should succeed.
Actual result
Accessibility error: select element missing an associated label.
HTML Validation errors: The align attribute on the img element is obsolete. Use CSS instead. / Element dl is missing a required child element.
Documentation Changes Required
none
Notes
I think this is not a bug, but this PR is a little help toward html conformance and accessibility.
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | Front End com_contact | ⇒ | Front End com_contact Templates (site) |
Can this be tagged with accessibility please?
| Category | Front End com_contact Templates (site) | ⇒ | Accessibility com_contact Front End Templates (site) |
done
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17602.
@LivioCavallo can't count your Test as you created this Pull request and its expected that Dev. test their PRs.
| Title |
|
||||||
Can I do anything to help drone to solve "volume not found" error?
I have restarted drone for you
I have tested this item
But I suggest you remove this vertical-align style. It's not needed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17602.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17602.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17602.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-22 12:02:59 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
The same fix applied to beez3 template contact view override