J3 Issue ?
avatar hfittipaldi
hfittipaldi
17 Aug 2017

Steps to reproduce the issue

Any subform with layout="joomla.form.field.subform.repeatable-table"

Expected result

The form style similar to others. Something like this:
screenshot-joomla-subform-repeatable-field-type

Actual result

A little bit unformatted:
screenshot-joomla-subform-field-type

System information (as much as possible)

PHP executando em – Windows NT 10.0 build 15063 (Windows 10) AMD64
Versão do Banco de Dados – 5.7.14
Versão do PHP – 5.6.30
Servidor Web – Apache/2.4.23 (Win64) OpenSSL/1.0.2j PHP/5.6.30
Versão do Joomla – Joomla! 3.7.4 Stable [ Amani ] 25-July-2017 11:11 GMT
Navegador do Usuário – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Additional comments

avatar hfittipaldi hfittipaldi - open - 17 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2017
Category Fields
avatar tonypartridge
tonypartridge - comment - 20 Aug 2017

So the table outputs in a table fashion. It looks like you just want repeatable.

If this isn't the case provide your whole JForm xml so we can see how you are creating it

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Aug 2017
Status New Information Required
avatar Fedik
Fedik - comment - 20 Aug 2017

I can confirm, the styling of table layout joomla.form.field.subform.repeatable-table looks really bad.
It has become bad after "flat styling" changes, or around this.

avatar tonypartridge
tonypartridge - comment - 20 Aug 2017

Working ok here... I styled a table yesterday.

Is it only a problem in the backend?

--
Tony Partridge

From: Fedir Zinchuk notifications@github.com notifications@github.com
Reply: joomla/joomla-cms
reply@reply.github.com
reply@reply.github.com
Date: 20 August 2017 at 17:08:32
To: joomla/joomla-cms joomla-cms@noreply.github.com
joomla-cms@noreply.github.com
CC: Tony Partridge admin@xtech.im admin@xtech.im, Comment
comment@noreply.github.com comment@noreply.github.com
Subject: Re: [joomla/joomla-cms] Sub Form Field styles problems (#17589)

I can confirm, the styling of table layout

joomla.form.field.subform.repeatable-table looks really bad.
It has become bad after "flat styling" changes, or around this.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#17589 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVgluZImhLVBmpMzsxNhJBONF4vFB2Jks5saFoAgaJpZM4O6tlf
.

avatar Fedik
Fedik - comment - 20 Aug 2017

ok, it better in recent update ?
but still some issue, try:

<field name="sebform1" type="subform" label="subform"
	layout="joomla.form.field.subform.repeatable-table" multiple="true" groupByFieldset="true">
	<form>
		<fieldset name="group1" label="group 1">
			<field type="text" name="text" label="text 1"/>
			<field type="text" name="text2" label="text 2"/>
			<field type="text" name="text3" label="text 3"/>
		</fieldset>
		<fieldset name="group2" label="group 2">
			<field type="text" name="text4" label="text 4"/>
			<field type="textarea" name="textarea" label="textarea"/>
		</fieldset>
	</form>
</field>

screen 2017-08-20 19 42 10 1161x278

yes, in the backend

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2017

@Fedik can you create a Pull Request for mentioned Issue?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17589.

avatar Fedik
Fedik - comment - 26 Aug 2017

I do not have a fix currently,

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2017

sorry, now i read again you have an Issue, not PR.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Oct 2017
Status Information Required Discussion
avatar hfittipaldi
hfittipaldi - comment - 22 Jan 2018

@Fedik , besides the style problem, do you also have problems with remove an empty field? I'm getting javascript error (Joomla 3.8.3 and 3.8.4-rc)

avatar Fedik
Fedik - comment - 22 Jan 2018

@hfittipaldi I do not have the problem with remove an empty field

avatar hfittipaldi
hfittipaldi - comment - 22 Jan 2018

Weird. I'm getting "Uncaught TypeError: Cannot read property 'id' of undefined" when I remove an empty record (not field, my bad)

avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar Quy
Quy - comment - 20 Apr 2018

It is because of line 7541 \administrator\templates\isis\css\template.css zeroing the bottom margin. I am not sure of the side-effects to removing it.

.subform-table-layout .control-group,
.subform-table-layout .control-group:last-of-type {
	margin-bottom: 0;
}

subform

avatar ciar4n
ciar4n - comment - 22 Apr 2018

This CSS was originally added here... #13769

Maybe something has changed since as the issue does not appear to be present in the screenshot of that pr. I'll have a look later.

avatar ciar4n
ciar4n - comment - 22 Apr 2018

Nothing has changed. Looks like I hadn't considered multiple field in each cell when creating the PR. I'll fix this.

avatar ciar4n
ciar4n - comment - 22 Apr 2018

PR created.. #20209

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Apr 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-04-22 09:58:26
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 22 Apr 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 22 Apr 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Apr 2018

closed as having Pull Request #20209

Add a Comment

Login with GitHub to post a comment