Feeling Lucky
[#1758] - New HTML5 attributes and refactored code with test. Feature #31347
- Closed
- 17 Aug 2013
- Medium
- Build: master
- # 1758
- Diff
- Achal-Aggarwal:gsoc-fields-attr
- Foreign ID 31347
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31347
Instructions
Just merge that code branch and use HTML5 attribute.
For attribute
- placeholder : use hint=”Placeholder text” to set placeholder
- required : use required=”true” or required=”required” or required=”1” to make field required
- autocomplete : use autocomplete=”false” or autocomplete=”off” or autocomplete=”0” to disable autocomplete.
- autofocus : use autofocus=”true” or autofocus=”on” or autofocus=”1” to set focus automatically to the field.
- spellcheck : use spellcheck =”false” or spellcheck =”off” or spellcheck =”0” to disable spellcheck.
- multiple : use multiple=”true” or multiple=”required” so that field can accept multiple values of its type.
There is little bit refactoring with respect to boolean attributes (disabled, readonly), so everything should work as it does previously.
For the non-supported browsers, fallback js is automatically loaded to support it
Usage of some common attributes are on http://docs.joomla.org/Text_form_field_type/3.2
Achal-Aggarwal
- comment
- 17 Aug 2013
Now Travis is passing.
I have created a new branch having single commit https://github.com/Achal-Aggarwal/joomla-cms/compare/gsoc-fields-attr-single-commit
davidhurley
- comment
- 17 Aug 2013
Thanks! Please submit that new branch as a PR and I'll close this one.
wilsonge
- comment
- 17 Aug 2013
If this has been replaced can you close this one please :)
So two things:
1) Can you please squash these commits? It's a 103! (@davidhurley made me say that)
2) You're failing the travis-ci, so you need to look at that and see what's up there.