Feeling Lucky
?
?
[#17533] - Move JHttpFactory::getHttp() into try catch and add error handling
- Fixed in Code Base
- 4 Nov 2017
- Medium
- Build: staging
- # 17533
- Diff
- zero-24:httptrycatch
User tests: Successful: Unsuccessful:
Summary of Changes
Move any usage of JHttpFactory::getHttp() into try catch and add error handling
This is a redo from #15388 cc @mbabker
Testing Instructions
Review.
Confirm that you can still uses a feed.
Confirm that recaptcha still works.
Expected result
everything still works
Actual result
everything works but without error handling
Documentation Changes Required
None.
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Status | Pending | ⇒ | Information Required |
SamuelSchepp
- comment
- 22 Aug 2017
I have tested this item
Tested as described in "Testing Instructions".
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17533.
| Status | Information Required | ⇒ | Pending |
Worti2
- comment
- 4 Nov 2017
I have tested this item
I tested this patch successfully.
Regards
Markus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17533.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-04 14:30:32 |
| Closed_By | ⇒ | mbabker | |
| Labels | |||
zero-24
- comment
- 4 Nov 2017
Thanks
Please provide instructions for testing a failed $reader->open, but a successful HttpFactory::getHttp.
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17533.