? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Aug 2017

Alternative to #17469

There are many possible ways to display a readmore link depending on the options chosen

  1. Read more
  2. Read more with title
  3. Read more with title limited to a set number of characters
  4. Register to Read more
  5. Register to Read more with title (Show unauthorised links)
  6. Register to Read more with title limited to a set number of characters (Show unauthorised links)
  7. As above with alternative Read More Text

Option 1 and 4 fails a11y as you end up with multiple links on the page all with the same title
Option 3 and 6 may fail a11y as the title may be truncated (even inside a word) and this can lose meaning and sometimes result on multiple links with the same title

To resolve this we can use the aria-label attribute on the link to ensure that assistive technology will always see a unique and meaningful link.

This alternative PR addresses the issues raised by @zwiastunsw

A) does not say that it is a continuation (Read more).
B) when access is for registered users - incorrectly states that this link and specifies where instead of message: Login to see

Testing Instructions

Create a series of articles with all the possible readmore options in a blog category and make sure that the visible links are the same with and without this PR.
If you view the source after the PR you will see appropriate text for the aria-label attribute of the href

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2017
Category Layout
avatar brianteeman brianteeman - open - 14 Aug 2017
avatar brianteeman brianteeman - change - 14 Aug 2017
Status New Pending
952ead0 14 Aug 2017 avatar brianteeman tabs
avatar brianteeman brianteeman - change - 14 Aug 2017
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Aug 2017
The description was changed
avatar brianteeman brianteeman - edited - 14 Aug 2017
avatar zwiastunsw zwiastunsw - test_item - 14 Aug 2017 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 14 Aug 2017

I have tested this item successfully on 952ead0

The best!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17530.

avatar chmst chmst - test_item - 14 Aug 2017 - Tested successfully
avatar chmst
chmst - comment - 14 Aug 2017

I have tested this item successfully on 952ead0

A good solution.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17530.

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Aug 2017

RTC after two successful tests.

avatar brianteeman
brianteeman - comment - 15 Aug 2017

Can this be merged as is and then I can test using sprintf etc over the next few days and create a new pr with that change if it will escape the data?

avatar mbabker
mbabker - comment - 15 Aug 2017

Will merge as soon as I've finished pushing beta 2 build.

avatar brianteeman
brianteeman - comment - 15 Aug 2017

Time to merge?

avatar mbabker mbabker - change - 15 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-15 16:19:55
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 15 Aug 2017
avatar mbabker mbabker - merge - 15 Aug 2017
avatar brianteeman
brianteeman - comment - 15 Aug 2017

Thanks. I will look at changing everything to sprintf if it is possible.

avatar infograf768
infograf768 - comment - 16 Aug 2017

Note: I guess RTL should also be corrected with this refactoring to icon-chevron-left instead of icon-chevron-right
We have
screen shot 2017-08-16 at 09 08 17
We should have imho
screen shot 2017-08-16 at 09 09 05

If we do not want to touch at the CSS, we can use something like
<?php $icon_chevron = JFactory::getLanguage()->isRTL() ? 'icon-chevron-left' : 'icon-chevron-right'; ?>
and where necessary
class="<?php echo $icon_chevron; ?>"

avatar brianteeman
brianteeman - comment - 16 Aug 2017

@infograf768 this is unrelated to this PR as it was broken before as well sadly - I will look at doing a pr to fix this issue

avatar brianteeman
brianteeman - comment - 16 Aug 2017

Add a Comment

Login with GitHub to post a comment