[#17530] - [a11y] Readmore links
- Fixed in Code Base
- 15 Aug 2017
- Medium
- Build: staging
- # 17530
- Diff
- brianteeman:readmore-alternative
- Pending continuous-integration/drone/pr this build is pending Details
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Alternative to #17469
There are many possible ways to display a readmore link depending on the options chosen
- Read more
- Read more with title
- Read more with title limited to a set number of characters
- Register to Read more
- Register to Read more with title (Show unauthorised links)
- Register to Read more with title limited to a set number of characters (Show unauthorised links)
- As above with alternative Read More Text
Option 1 and 4 fails a11y as you end up with multiple links on the page all with the same title
Option 3 and 6 may fail a11y as the title may be truncated (even inside a word) and this can lose meaning and sometimes result on multiple links with the same title
To resolve this we can use the aria-label attribute on the link to ensure that assistive technology will always see a unique and meaningful link.
This alternative PR addresses the issues raised by @zwiastunsw
A) does not say that it is a continuation (Read more).
B) when access is for registered users - incorrectly states that this link and specifies where instead of message: Login to see
Testing Instructions
Create a series of articles with all the possible readmore options in a blog category and make sure that the visible links are the same with and without this PR.
If you view the source after the PR you will see appropriate text for the aria-label attribute of the href
joomla-cms-bot
- | Category | ⇒ | Layout |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
A good solution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17530.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Can this be merged as is and then I can test using sprintf etc over the next few days and create a new pr with that change if it will escape the data?
Will merge as soon as I've finished pushing beta 2 build.
Time to merge?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-15 16:19:55 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks. I will look at changing everything to sprintf if it is possible.
Note: I guess RTL should also be corrected with this refactoring to icon-chevron-left instead of icon-chevron-right
We have
We should have imho
If we do not want to touch at the CSS, we can use something like
<?php $icon_chevron = JFactory::getLanguage()->isRTL() ? 'icon-chevron-left' : 'icon-chevron-right'; ?>
and where necessary
class="<?php echo $icon_chevron; ?>"
@infograf768 this is unrelated to this PR as it was broken before as well sadly - I will look at doing a pr to fix this issue
@infograf768 see #17560
I have tested this item✅ successfully on 952ead0
The best!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17530.