? ? Pending

User tests: Successful: Unsuccessful:

avatar zwiastunsw
zwiastunsw
13 Aug 2017

a11y improvement: Blog category - Restore More Articles heading and change the article list tag

Summary of Changes

  1. Restore the "More Articles..." headings
  2. Change the tags from the list ordered to the unordered list

Testing Instructions

  1. Create a category blog page with many articles
  2. Set the #Links option to 4 for example
  3. Check the category blog page:
  • Does the link to other articles precede the h3 header "More Articles..."?
  • Is the list of links an unordered list?

Expected result

  1. The link to other articles does precede the h3 header "More Articles..."
  2. The list of links is an unordered list
    WCAG 2.0 Success criteria: 1.3.1, 2.4.6, 2.4.10

Actual result

The section links to other articles in the category is not tagged.
An ordered list marker is used for the tag. The order of items in this list is irrelevant. This should be an unordered list.

Documentation Changes Required

No changes to the documentation required - no new functionality introduced.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2017
Category Front End com_content
avatar zwiastunsw zwiastunsw - open - 13 Aug 2017
avatar zwiastunsw zwiastunsw - change - 13 Aug 2017
Status New Pending
avatar zwiastunsw zwiastunsw - change - 13 Aug 2017
Title
a11y improv: Blog cat - Restore More Articles heading...
[a11y] Blog cat - Restore More Articles heading...
avatar zwiastunsw zwiastunsw - edited - 13 Aug 2017
avatar brianteeman
brianteeman - comment - 13 Aug 2017

Sorry I do not agree with reverting the removal of the More Articles heading

avatar brianteeman
brianteeman - comment - 13 Aug 2017

also the list of links do have an order eg date so they should be an ordered list
https://www.w3.org/TR/WCAG20-TECHS/H48.html

avatar zero-24 zero-24 - change - 13 Aug 2017
Labels Added: ?
avatar zwiastunsw
zwiastunsw - comment - 13 Aug 2017
  1. Sorry I do not agree with reverting the removal of the More Articles heading

This header is needed for people with cognitive difficulties. Help is also available to visually impaired people using a screen magnifiers. For such individuals the content should be clear and simple. One of the techniques is to use meaningful headings and subheadings.

  1. About list

An ordered list is used only when a sequential order need to be maintained. When describing a process of doing a task. For instance, a step by step procedure followed to prepare tea.
When you apply the standard formatting of an ordered list, the links will be numbered: 1, 2, 3 ... What makes sense? Nothing!
The fact that articles are sorted, e.g. in chronological order does not matter. For a user this sorting criterion is not visible. Depending on the settings, they can be sorted according to different criteria.

avatar chmst chmst - test_item - 13 Aug 2017 - Tested successfully
avatar chmst
chmst - comment - 13 Aug 2017

I have tested this item successfully on 96977f2

Thank you for the additional information. @zwiastunsw


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17524.

avatar brianteeman
brianteeman - comment - 13 Aug 2017
  1. This is the role of the template and not Joomla
  2. You are wrong. It is an ordered list and not some random collection of links. You have no way of knowing if it is a set of instructions to follow or a series of articles that should be read if you remove the ordered list.
avatar zwiastunsw
zwiastunsw - comment - 13 Aug 2017
  1. Role of template? Yes, I'm improving the template (view).
  2. Thinking of your course, you should use an ordered list in the menu. Because it's not a random mix of links.
avatar wojsmol
wojsmol - comment - 13 Aug 2017

@zero-24 Plese restart travis build for php 5.4 and 7.1.

avatar zero-24
zero-24 - comment - 13 Aug 2017

done

avatar brianteeman
brianteeman - comment - 13 Aug 2017

By adding the text More Articles to all sites you are breaking them. On my site I have one category that is for Lessons and another for videos. So saying more articles is wrong. O cannot do a language override either because it is the same view so I would have to create multiple overides of the view just to get back to the way my site was designed before this pr broke it.

Why should I have to change my site to use a menu for each lesson. That's crazy! It is an ordered list. It should stay an ordered list and not be changed into an unordered list. Even though I have used core features of Joomla to make that ordering this pr decides that it's not ordered.

This is not improving accessibility pr cognitive understanding.

avatar zwiastunsw
zwiastunsw - comment - 13 Aug 2017
  1. This is neither a great nor a particularly important matter.
    That is why I will not insist on my opinion.
    However, we definitely have a different section on the site than the previous one, so this header makes it easy to orient, improve the organization of the page. Maybe another header text?
  2. OK. So why do we have an unordered list in the module mod_articles_latest? Why do we have an unordered list in the module mod_articles_popular? Where is the consistency here?
avatar brianteeman
brianteeman - comment - 13 Aug 2017

Why is it a different section? To me it's just a different display the content is still of the same type

avatar mbabker
mbabker - comment - 13 Aug 2017
  1. This changes output on all sites using the default layouts, we have a standing policy of being careful about this. The pros must outweigh the cons.

  2. Just because things are inconsistent or done one way somewhere else doesn't necessarily make them right. At the end of the day it's all going to boil down to context I guess.

avatar zwiastunsw
zwiastunsw - comment - 13 Aug 2017

@brianteeman: It's hard for you to refuse. This is not a completely different section. But before you have the intro to the articles, and here only the links
@mbabker
2. In my opinion, the unordered list in these modules is applied correctly.

avatar brianteeman
brianteeman - comment - 20 Aug 2017

I have thought about this some more and I now agree that it should be an unordered list. This is because I still believe this is not a new section but a continuation of the articles displayed with intro paragraphs and therefore these are not number 1,2,3,4 but 9,10,11,12 etc so my argument for them to be ordered while still valid makes no sense

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on 96977f2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17524.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 26 Oct 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar brianteeman
brianteeman - comment - 26 Oct 2017

This needs careful consideration before merging
#17524 (comment)

avatar mbabker
mbabker - comment - 1 Nov 2017

I don't think this should merge with the heading addition. As I said before, for better or worse we keep disruptive output changes to a minimum and this is a disruptive output change (and honestly one that is highly opinionated).

avatar zwiastunsw
zwiastunsw - comment - 1 Nov 2017

OK. I withdraw. I have no strength to discuss. Now I understand why good programmers don't report PR. Because instead of support, improvements, they encounter resistance from "scholars in writing".
There is no doubt that this PR improves the experience of blind users. It is easier to say that it is evil and to reject it than to improve it. And it would only be suggested to add CSS class to the header: element-invisible.

avatar mbabker
mbabker - comment - 1 Nov 2017

Even if the CSS class were added to the new heading, for templates that don't implement it it still results in a new heading being displayed on sites after update that they may or may not want (or on the other hand may or may not care about). Yes, it is an improvement for certain scenarios, I don't think anyone has flat out said that it is not, but there is a lot more to take into consideration than "this makes something better, push it to everybody".

Unfortunately we can't just accept every feature or pull request because somebody put the effort into it.

avatar brianteeman
brianteeman - comment - 6 Jan 2018

Closed for the reasons stated above

avatar brianteeman brianteeman - change - 6 Jan 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-01-06 19:53:48
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 6 Jan 2018

Add a Comment

Login with GitHub to post a comment