User tests: Successful: Unsuccessful:
a11y improvement: Blog category - Restore More Articles heading and change the article list tag
The section links to other articles in the category is not tagged.
An ordered list marker is used for the tag. The order of items in this list is irrelevant. This should be an unordered list.
No changes to the documentation required - no new functionality introduced.
Category | ⇒ | Front End com_content |
Status | New | ⇒ | Pending |
Title |
|
also the list of links do have an order eg date so they should be an ordered list
https://www.w3.org/TR/WCAG20-TECHS/H48.html
Labels |
Added:
?
|
Sorry I do not agree with reverting the removal of the More Articles heading
This header is needed for people with cognitive difficulties. Help is also available to visually impaired people using a screen magnifiers. For such individuals the content should be clear and simple. One of the techniques is to use meaningful headings and subheadings.
An ordered list is used only when a sequential order need to be maintained. When describing a process of doing a task. For instance, a step by step procedure followed to prepare tea.
When you apply the standard formatting of an ordered list, the links will be numbered: 1, 2, 3 ... What makes sense? Nothing!
The fact that articles are sorted, e.g. in chronological order does not matter. For a user this sorting criterion is not visible. Depending on the settings, they can be sorted according to different criteria.
I have tested this item
Thank you for the additional information. @zwiastunsw
done
By adding the text More Articles to all sites you are breaking them. On my site I have one category that is for Lessons and another for videos. So saying more articles is wrong. O cannot do a language override either because it is the same view so I would have to create multiple overides of the view just to get back to the way my site was designed before this pr broke it.
Why should I have to change my site to use a menu for each lesson. That's crazy! It is an ordered list. It should stay an ordered list and not be changed into an unordered list. Even though I have used core features of Joomla to make that ordering this pr decides that it's not ordered.
This is not improving accessibility pr cognitive understanding.
Why is it a different section? To me it's just a different display the content is still of the same type
This changes output on all sites using the default layouts, we have a standing policy of being careful about this. The pros must outweigh the cons.
Just because things are inconsistent or done one way somewhere else doesn't necessarily make them right. At the end of the day it's all going to boil down to context I guess.
@brianteeman: It's hard for you to refuse. This is not a completely different section. But before you have the intro to the articles, and here only the links
@mbabker
2. In my opinion, the unordered list in these modules is applied correctly.
I have thought about this some more and I now agree that it should be an unordered list. This is because I still believe this is not a new section but a continuation of the articles displayed with intro paragraphs and therefore these are not number 1,2,3,4 but 9,10,11,12 etc so my argument for them to be ordered while still valid makes no sense
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
This needs careful consideration before merging
#17524 (comment)
I don't think this should merge with the heading addition. As I said before, for better or worse we keep disruptive output changes to a minimum and this is a disruptive output change (and honestly one that is highly opinionated).
OK. I withdraw. I have no strength to discuss. Now I understand why good programmers don't report PR. Because instead of support, improvements, they encounter resistance from "scholars in writing".
There is no doubt that this PR improves the experience of blind users. It is easier to say that it is evil and to reject it than to improve it. And it would only be suggested to add CSS class to the header: element-invisible.
Even if the CSS class were added to the new heading, for templates that don't implement it it still results in a new heading being displayed on sites after update that they may or may not want (or on the other hand may or may not care about). Yes, it is an improvement for certain scenarios, I don't think anyone has flat out said that it is not, but there is a lot more to take into consideration than "this makes something better, push it to everybody".
Unfortunately we can't just accept every feature or pull request because somebody put the effort into it.
Closed for the reasons stated above
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-06 19:53:48 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
|
Sorry I do not agree with reverting the removal of the More Articles heading