User tests: Successful: Unsuccessful:
Pull Request for Issue #17406 .
Admin Menus:
Show language icons for menus which contain home menu items for a language. And home icon which contains global home page.
For details please refer to the mentioned issue #17406
Create menu items under different menus and set some menu items as default for different languages in each menu type.
Respective language flags should be displayed in admin menu "Menu" dropdown.
None
Category | ⇒ | Administration com_menus Modules Libraries |
Status | New | ⇒ | Pending |
Why is this introducing a css file instead of using the images as before?
Its a little more complex as a result as if we add a language or flag then the css will need to be updated as well
I am adding this to make it reusable at other places (core or custom
extensions) with a simple icon class instead of full IMG tag. That's why I
left it within the mod_languages context instead of adding in mod_menu.
Updating CSS should not be an issue IMHO.
for me that change is beyond the scope of this PR.
Labels |
Added:
?
|
@brianteeman Please have a look at this now. I have removed the CSS definitions and usage.
I have tested this item
@izharaazmi
Works fine here and I set my test OK.
I suggest to make another PR (or add in this one) to take care of the situation where, by mistake or db corruption, 2 or more Home pages exist in a single menuType.
This was taken care of previously when we had
elseif ($menuType->home > 1)
{
$titleicon = ' <span>'
. JHtml::_('image', 'mod_languages/icon-16-language.png', $menuType->home, array('title' => JText::_('MOD_MENU_HOME_MULTIPLE')), true)
. '</span>';
}
with the existing string
MOD_MENU_HOME_MULTIPLE="Warning! Multiple homes!"
To test this, create a multilang site as usual, define a flag/icon for a content language then in the db, set to home another menu item than the usual home for that language in the same menu type.
We will get correctly the generic icon in the menu. Here for German main menu:
But I think we should also display a warning in the Menu items Manager and modify the value of this lang string to include the name of the menutype with a sprintf.
Can do?
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@infograf768 It's already taken care of. Please let me know if it's failing.
Though the warning is not displayed. We can do that in another PR.
@izharaazmi
Ok for another PR.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-13 15:38:40 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
@infograf768 Please test this one.