? ? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
12 Aug 2017

Pull Request for Issue "need LDAP for some future testing"
See comment for request from @wilsonge #17081 (comment)

Summary of Changes

Follow symfony/polyfill appveyor setup https://github.com/symfony/polyfill/blob/master/appveyor.yml to enable LDAP

Testing Instructions

merge by code review

Expected result

Appveyor tests pass and do not throw warnings like missing extension

Documentation Changes Required

none

avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2017
Category Unit Tests
avatar photodude photodude - open - 12 Aug 2017
avatar photodude photodude - change - 12 Aug 2017
Status New Pending
avatar photodude
photodude - comment - 12 Aug 2017

@wilsonge @mbabker Any thoughts on how to verify that this worked (other than just throwing php -m into appveyor to get an echo list)?

avatar wilsonge
wilsonge - comment - 12 Aug 2017

Take back out --ignore-platform-reqs from composer install and see if composer now installs dependencies on appveyor?

avatar photodude photodude - change - 14 Aug 2017
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 14 Aug 2017

Merged on review. Appveyor composer install now works (the fails are cause of libsodium polyfill) and drone also unrelated

avatar wilsonge wilsonge - change - 14 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-14 00:43:05
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Aug 2017
avatar wilsonge wilsonge - merge - 14 Aug 2017
avatar photodude
photodude - comment - 14 Aug 2017

Thanks @wilsonge

Add a Comment

Login with GitHub to post a comment