? Pending

User tests: Successful: Unsuccessful:

avatar LivioCavallo
LivioCavallo
11 Aug 2017

On user-specified redirect after article saving in frontend, the code uses JRoute constructor to build url, but doing so it uses a default parameter that erroneously leads to encoding all the url query part, so converting '&' to ' & amp;' (entity, without space).
That is not correct and may lead to components error or malfunction, particularly in the case of third party components, as they could not be able to get Itemid param and all the other query params.

The same problematic default parameter is used in case of cancel and of edit error (same class, cancel and edit function), that redirects to return page (via getReturnPage).

Summary of Changes

Add 'false' as second parameter in four JRoute constructors calls

Testing Instructions

Create a menuitem to show list of articles of 'uncategorized' type
Create a menuitem to Submit New Article and specify a redirect after submit to previous menuitem.
Submit a new article

Expected result

redirection to: index.php?option=com_content&view=category&id=mm&Itemid=nnn

Actual result

redirection to: index.php?option=com_content& amp;view=category& amp;id=mm& amp;Itemid=nnn (entities, without spaces)

Documentation Changes Required

none

avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2017
Category Front End com_content
avatar LivioCavallo LivioCavallo - open - 11 Aug 2017
avatar LivioCavallo LivioCavallo - change - 11 Aug 2017
Status New Pending
avatar infograf768 infograf768 - test_item - 12 Aug 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 12 Aug 2017

I have tested this item successfully on 3d67d50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17494.

avatar crleathers crleathers - test_item - 12 Aug 2017 - Tested successfully
avatar crleathers
crleathers - comment - 12 Aug 2017

I have tested this item successfully on 3d67d50

Tested the patch successfully in a clean build of 3.8 beta


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17494.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Aug 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 13 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-13 15:41:18
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 13 Aug 2017
avatar mbabker mbabker - merge - 13 Aug 2017

Add a Comment

Login with GitHub to post a comment