? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
10 Aug 2017

Pull Request for Issue # .

Summary of Changes

Removes the following...

templates/system/css/system.css
templates/system/css/toolbar.css
templates/system/images/

Testing Instructions

Code review

avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2017
Category Front End Templates (site)
avatar ciar4n ciar4n - open - 10 Aug 2017
avatar ciar4n ciar4n - change - 10 Aug 2017
Status New Pending
avatar brianteeman
brianteeman - comment - 10 Aug 2017

In theory the system.css is being used - at least for the first class
system-unpublished

although it doesnt appear to be working

avatar mbabker
mbabker - comment - 10 Aug 2017

None of the system template layouts include the system.css file. So it's totally unused.

Theoretically, even if it were included, the only time you would actually see it do something is if the component.php template file were in use and a template didn't provide their own version of it. The error and offline layouts won't show content using that class. And if your template doesn't have the index.php file then why did you install the template to begin with!?

avatar N6REJ
N6REJ - comment - 11 Aug 2017

should the .css referenced by -@import url(../../../media/system/css/system.css); be removed also?

avatar ciar4n
ciar4n - comment - 11 Aug 2017

@N6REJ We are only removing ../templates/system/css/system.css

../media/system/css/system.css remains.

avatar wilsonge wilsonge - change - 12 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-12 18:31:46
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 Aug 2017
avatar wilsonge wilsonge - merge - 12 Aug 2017

Add a Comment

Login with GitHub to post a comment