? ? Pending

User tests: Successful: Unsuccessful:

avatar 123monsite-regis
123monsite-regis
10 Aug 2017

Pull Request for Issue # .

Summary of Changes

Administrator : User list : modal view : un-activated icon not shown in certain cases
field was cast to int instead if empty or not.
it is done after this patch as on default users list view : https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/views/users/tmpl/default.php#L137

Testing Instructions

  • create a certain number of users, activated and unactivated ones
  • find a modal user list view on administrator ( you have them for example on com_content > articles > author, but you can also create a new wondefull 3.7's custom field of type user)
  • then you can see the modal view

Expected result

exepcted

Actual result

actual

Documentation Changes Required

none

avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2017
Category Administration com_users
avatar 123monsite-regis 123monsite-regis - open - 10 Aug 2017
avatar 123monsite-regis 123monsite-regis - change - 10 Aug 2017
Status New Pending
avatar 123monsite-regis 123monsite-regis - change - 10 Aug 2017
The description was changed
avatar 123monsite-regis 123monsite-regis - edited - 10 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Aug 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Aug 2017

I have tested this item successfully on 55b5e5e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17463.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Aug 2017
Easy No Yes
avatar bayareajenn bayareajenn - test_item - 12 Aug 2017 - Tested successfully
avatar bayareajenn
bayareajenn - comment - 12 Aug 2017

I have tested this item successfully on 55b5e5e

Was able to duplicate issue and resolve with the patch. :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17463.

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Aug 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 13 Aug 2017

#17463 (comment) has first to be corrected before merging

avatar brianteeman brianteeman - change - 13 Aug 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 13 Aug 2017

I have fixed the codestyle issue that @infograf768 refers to above

avatar 123monsite-regis
123monsite-regis - comment - 13 Aug 2017

thanks for the tests and the fix of the extra-space,
have a nice day.

avatar mbabker mbabker - change - 13 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-13 15:41:42
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 13 Aug 2017
avatar mbabker mbabker - merge - 13 Aug 2017

Add a Comment

Login with GitHub to post a comment