?
avatar alikon
alikon
9 Aug 2017

Steps to reproduce the issue

Users -> manage
click on searchtools

Expected result

filter fields are correctly populated and you are able to filter user data
screenshot from 2017-08-09 18-38-18

Actual result

screenshot from 2017-08-09 18-39-11

with modal
screenshot from 2017-08-09 17-41-04

System information (as much as possible)

3.8.0-beta
firefox 54

avatar alikon alikon - open - 9 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Aug 2017
Category com_search
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Aug 2017

Can't confirm. Search Tools are shown and working as expected.

System information

3.8-dev
Multilanguage Site
macOS Sierra, 10.12.6
Firefox 55 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2017
Status New Discussion
avatar alikon
alikon - comment - 10 Aug 2017

made a pr #17477

avatar alikon alikon - change - 10 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-10 19:18:02
Closed_By alikon
avatar alikon alikon - close - 10 Aug 2017
avatar laoneo
laoneo - comment - 15 Aug 2017

As class names are not case sensitive in PHP and we have a convention that form files do exist in lowercase name this code loads the class in < 3.8. Now it is different, so we need to find a way to have the same set up. I will check it in the next few days for a proper solution. Till then I suggest to close the pr #17477 and reopen this one and mark it as release blocker.

avatar mbabker
mbabker - comment - 15 Aug 2017

That line is only problematic if you're scanning the filesystem to find a not-yet-loaded class, it won't be hit if something hits the autoloader first. What we have in the class mapping file won't work for these fields because their properly declared cases aren't anything that were ever autoloaded to begin with, so for form fields we might need to just uppercase the first character after JFormField and leave everything after lowercased.

avatar mbabker mbabker - change - 15 Aug 2017
Labels Added: ?
avatar mbabker mbabker - labeled - 15 Aug 2017
avatar alikon
alikon - comment - 15 Aug 2017

reopen as requested

avatar alikon alikon - change - 15 Aug 2017
Status Closed New
Closed_Date 2017-08-10 19:18:02
Closed_By alikon
avatar alikon alikon - reopen - 15 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Aug 2017
Status New Discussion
avatar laoneo
laoneo - comment - 17 Aug 2017

Please test #17584, it should fix the issue.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-17 14:04:01
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 17 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Aug 2017

closed as having Pull Request #17584


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17460.

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Aug 2017
avatar zero-24 zero-24 - change - 16 Oct 2017
Labels Removed: ?
avatar zero-24 zero-24 - unlabeled - 16 Oct 2017

Add a Comment

Login with GitHub to post a comment