[#17424] - [4.0] Sample data fix wrapper
- Fixed in Code Base
- 7 Aug 2017
- Medium
- Build: 4.0-dev
- Easy Test
- # 17424
- Diff
- brianteeman:wrapper
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Update the sample data to use width 100% for the wrapper to fix #17404
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
Given the merge of the Sample Data module/plugin into 3.8, the Sample Data installer and the respective SQL files will likely be removed from 4.0. So this is probably not worth pursuing anymore
This Ims for the testing data and not the end user sample data
Same thing. Testing data is a plugin as well in 3.8.
I guess this can be closed.
Until we reach a state where the workflow has changed, the status quo is still in effect so we might as well keep fixing things. Worst thing we do is waste 2-3 minutes of someone's time, but we really don't want to push away legitimate fixes because something may be replaced later.
Why was the plugin for sample data was put in 3.8 and not 4?
Considering a lot of sample data has been changed for 4 and there's still a load to come, I can't see any logic in it being in 3.8
The module/plugin stuff is just architecture. And the existing sets converted to demonstrate that architecture. For 4.0 you'll just implement your own plugin with the same data set.
So please can we merge this into 4 now even if it may be removed later
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-07 12:29:40 |
| Closed_By | ⇒ | mbabker |
Thank you
I have tested this item✅ successfully on d3887cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17424.