Feeling Lucky
?
[#17404] - [4.0] Sample Sites: Wrapper-Module to width
- Closed
- 6 Aug 2017
- Medium
- Build: staging
- # 17404
Steps to reproduce the issue
Comparing Screenshots below shows Wrapper-Module to width:
System information
4.0.0-dev
macOS Sierra, 10.12.6
Firefox 54 (64-bit)
MAMP 4.1.1
- PHP 7.0.15
- MySQLi 5.6.35
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Layout UI/UX |
brianteeman
- comment
- 6 Aug 2017
The default width is 100% already
https://github.com/joomla/joomla-cms/blob/4.0-dev/modules/mod_wrapper/mod_wrapper.xml#L60
brianteeman
- comment
- 6 Aug 2017
Ah I see what you mean now - its a mistake in the sample data
C-Lodder
- comment
- 6 Aug 2017
Yup, but I'm referring to the sample data, which sets a value of 640.
brianteeman
- comment
- 6 Aug 2017
cross-posted ;)
brianteeman
- comment
- 6 Aug 2017
I will do a PR now to fix that
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-06 12:17:01 |
| Closed_By | ⇒ | brianteeman |
@ciar4n - how should we go about this one? There's a
widthparameter for the iframe in the wrapper module, which by default is set to640px.Do we just adjust the sample data and set it to
100%?