Feeling Lucky
?
[#17396] - [fix] nested mode for tags field
- Fixed in Code Base
- 3 Aug 2017
- Medium
- Build: staging
- # 17396
- Diff
- phproberto:nested-tags
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17386
Summary of Changes
Nested mode for tags field is never detected as active because it's using:
$this->element['mode'] === 'nested'which returns false because $this->element['mode'] is a SimpleXMLElement object. It should be casted to string:
(string) $this->element['mode'] === 'nested'Testing Instructions
Apply the patch and check that tags filter on articles view filters is shown as a category field (with dashes).
Expected result
Actual result
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
brianteeman
- comment
- 3 Aug 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17396.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 3 Aug 2017
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-03 12:12:46 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 78473c5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17396.