[#17387] - Changed Update Notification Version compare
- Fixed in Code Base
- 4 Aug 2017
- Medium
- Build: staging
- # 17387
- Diff
- tonypartridge:staging-update-notifcation-version-compare
User tests: Successful: Unsuccessful:
Changed Update Notification Version compare to use le = Less than or Equal to. In some cases the users have updated the site before they have been notified within Joomla! i.e. a 3rd part component. Then the localised Joomla! install is stuck in the past and given it no longer equals to it informs the users constantly.
Pull Request for Issue #17299 .
Summary of Changes
version compare from GT to LE
Testing Instructions
Install Joomla! 3.7.3 and then setup update notifications, ensure you still get notified about V3.7.4 update.
Changed Update Notification Version compare to use le = Less than or Equal to. In some cases the users have updated the site before they have been notified within Joomla! i.e. a 3rd part component. Then the localised Joomla! install is stuck in the past and given it no longer equals to it informs the users constantly.
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I'm not sure what this "@joshelmich @pacman10 can you please test this Pull Request?" means (I don't know what a Pull Request is). It contains my username. Am I supposed to do something with it ? Happy to help but need guidance. Thanks.
Every Pull Request (PR) needs 2 successfully Tests. You wrote on issue #17299 and this PR try to solve the issue.
Please read https://brian.teeman.net/joomla/a-dummies-guide-to-joomla-bug-testing and help solving this Issue by test.
Should not it be <= ?
<= is the same as le.
See:
http://php.net/manual/en/function.version-compare.php
Given we were using eq, I kept it similar.
Correct indeed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17387.
I have tested this item
Modified the plugin with this PR on a 3.7.3 site and got the mail fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17387.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17387.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-04 11:28:54 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@joshelmich @pacman10 can you please test this Pull Request?