[#17383] - Category select list indent
- Fixed in Code Base
- 3 Aug 2017
- Medium
- Build: staging
- # 17383
- Diff
- brianteeman:categoryindent
User tests: Successful: Unsuccessful:
Pull Request for Issue #17380 .
Summary of Changes
If you select a category in Searchtools the categories are displayed like that:
If you select it in the Article, the Parent item has already a dash in front:
So in one case its:
Category Parent
- category child
and in the other case
- Category Parent
-- category child
UPDATED
I have adjusted the select box in the Category select
Test instructions
- Create a main category and sub category
- Observe that in the category select for a new item they are all displayed with at least one - dash
- Apply the PR and observe that parents no longer have a - dash
- Unpublish categories and observe that they are still wrapped in [] eg [unpublished category]
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Imho, the display in the SearchTools is correct, not the one in categoryedit field type
ok - i will switch it around
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-02 09:50:23 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
I solved it here by adding
if ($options[$i]->level != 0)
{
$options[$i]->level = $options[$i]->level -1;
}
in categoryedit.php line 245
the reason is that the same type is used for com_categories parent and articles categories.
Thanks I have already made the change and will commit it this afternoon when I get home from a funeral. Will also add indents to the tag search tool filter as well
| Category | Libraries | ⇒ | Administration com_categories |
| Category | ⇒ | Administration com_categories |
Updated PR and test instructions
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-08-02 09:50:23 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17383.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17383.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-03 16:51:22 |
| Closed_By | ⇒ | mbabker |
Thanks
I have tested this item✅ successfully on 4af9648
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17383.