? ? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
1 Aug 2017

Summary of Changes

  1. Correct the order of parameters for $handler->store().
  2. Backend -> System -> Clear cache: Add html escape for input value.

Testing Instructions

  1. Install J3.8

  2. Enable redis cache as example below (to test you can also use cache lite):
    obraz

  3. In order to see more errors change default front-end template to Beez3

  4. Open a new tab to see home page

  5. Go to Backend -> System -> Clear cache
    You should see something like below:

obraz

  1. You can not delete single cache group if it contains " (double quote)
  2. Apply this patch
  3. Now you can delete such single cache group.
  4. After you clear all cache, Joomla does not show more cache groups with suffix _lock or similar to menu_items{"menutype":"mainmenu","startLevel":...

Above points are detailed for redis but for cache lite should be similar.

Expected result

Cache item groups does not contains examples as below.

Actual result

There are weird cache item groups:

  • Joomla\CMS\Helper\LibraryHelper::loadLibraryjoomla_lock
  • menu_items{"menutype":"mainmenu","startLevel":"0","endLevel":"0","showAllChildren":"1","tag_id":"","class_sfx":"","window_open":"","layout":"","moduleclass_sfx":"_

Documentation Changes Required

No

avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2017
Category Administration com_cache Libraries
avatar csthomas csthomas - open - 1 Aug 2017
avatar csthomas csthomas - change - 1 Aug 2017
Status New Pending
avatar csthomas csthomas - change - 2 Aug 2017
The description was changed
avatar csthomas csthomas - edited - 2 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2017

Dropdown-Menu "Cache Handler" shows only "File" – how to get "Redis", didn't found a Plugin?

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Aug 2017
Status Pending Discussion
avatar brianteeman
brianteeman - comment - 2 Aug 2017

@franz-wohlkoenig if I remember correctly it will only show redistributed if it is available in your server

avatar alikon
alikon - comment - 2 Aug 2017

yes confirm (same as postgres/mssql)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Aug 2017

thanks for Info, @brianteeman and @alikon, i test local Mamp.

avatar csthomas
csthomas - comment - 2 Aug 2017

Php must have installed/enabled php-redis extension and a redis server available on a specified port.

avatar mbabker
mbabker - comment - 2 Aug 2017

I forget how flexible MAMP is with installing addons, but for those running a PHP build using Homebrew, same thing I posted in another issue works for installing/running Redis.

brew install redis
brew install phpxx-redis (replace xx with the PHP version you're using)
brew services start redis
avatar csthomas csthomas - change - 14 Aug 2017
Labels Added: ?
avatar csthomas csthomas - change - 26 Sep 2017
The description was changed
avatar csthomas csthomas - edited - 26 Sep 2017
avatar csthomas csthomas - change - 26 Sep 2017
Title
Small cache fix
Fix delete cache items from redis and others
avatar csthomas csthomas - edited - 26 Sep 2017
avatar paoprod paoprod - test_item - 26 Sep 2017 - Tested successfully
avatar paoprod
paoprod - comment - 26 Sep 2017

I have tested this item successfully on 20a7f36

Tested with Cache_Lite option in Cache Handler (here #18115 ). Work fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17381.

avatar jv5
jv5 - comment - 8 Oct 2017

Unable to Clear Cache after Joomla 3.8 update

I've had Cache_Lite enabled on a VPS with Siteground. After the 3.8 Joomla update, I was unable to clear the cache by going to System/Clear Cache. I would receive "JFolder: :folder: Path is not a folder...." warning messages as well when I tried to "Delete All" in the Clear Cache screen.

I had posted this issue on Joomla.org and was directed to post my info here on this discussion.

I saw this github post earlier but wasn't sure it applied to my situation since I am not using redis. I went ahead and changed the two files but getting the same results. Lots of files remain, like this one:

2067144f1dcc5440579e377e476ea4509c8101_lock

So I set the handler from cache_lite to Files. Executed "Clean Cache" and all files in the cache were deleted, except these two:

Joomla\CMS\Component\ComponentHelper::load_lock
Joomla\CMS\Helper\LibraryHelper::loadLibraryjoomla_lock

I also see this warning on the same screen:

...../libraries/src/Cache/Storage/FileStorage.php on line 167
Warning: Invalid argument supplied for foreach() in ..../libraries/src/Cache/Storage/FileStorage.php on line 167

Along with these warning messages:

Joomla\CMS\Cache\Storage\FileStorage::_filesInFolder JFolder: :delete: Path is not a folder. Path: /...../cache/Joomla/CMS/Component/ComponentHelper::load_lock
Joomla\CMS\Cache\Storage\FileStorage::_folders JFolder: :delete: Path is not a folder. Path: /....../cache/Joomla/CMS/Component/ComponentHelper::load_lock

Hopefully some info you guys can use.
jv

avatar csthomas
csthomas - comment - 9 Oct 2017

I'm not sure that you correctly replace patched files.
First, set cache handler to cache_lite, turn off cache for a while. Replace patched files again. Go to clear cache and delete all. Enable cache (cache_lite) - set conservative cache on.

Open home page in a new tab. Go to cache list and delete all cache. Please describe your result.

avatar jv5
jv5 - comment - 9 Oct 2017

@csthomas, I have followed your instructions and can confirm that the issue on my end has resolved. The functions appear to be working properly.

Thank you for your assistance.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Oct 2017

@jv5 if your Comment above means you have test this Pull Request, please mark your Test as successfully at Issue Tracker:

  • Please open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar alikon alikon - test_item - 10 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 10 Oct 2017

I have tested this item successfully on 20a7f36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17381.

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Oct 2017
Status Discussion Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 10 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-10 11:46:47
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 10 Oct 2017
avatar mbabker mbabker - merge - 10 Oct 2017
avatar jv5 jv5 - test_item - 10 Oct 2017 - Tested successfully
avatar jv5
jv5 - comment - 10 Oct 2017

I have tested this item successfully on 20a7f36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17381.

Add a Comment

Login with GitHub to post a comment