[#17373] - JFormFieldVotelist extends wrong field #17370
- Fixed in Code Base
- 21 Aug 2017
- Medium
- Build: staging
- Easy Test
- # 17373
- Diff
- brianteeman:voteradio
User tests: Successful: Unsuccessful:
The custom field for votelist is extending JFormFieldList but it should be extending JFormFieldRadio so that the field is displayed as a show/hide switch and not a dropdown select
This PR replaces the votelist field with a voteradio field (as it is a custom field for the component I replaced votelist - i can always put it back and mark it as deprecated and unused but I dont "think" thats required
Before
After
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_content |
| Status | New | ⇒ | Pending |
make sure you have the vote plugin enabled
I have tested this item
Sorry, haven't enabled Plugin before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.
| Easy | No | ⇒ | Yes |
could someone restart drone please as it timedout
could someone restart drone please as it timedout
done. Just ping me where needed so it don't get lost in all of my notifications ;)
Could you please add a test introduction.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.
- enable plugin "Content - Vote"
- open "Articles: Options"
- go Tab "List Layouts". Ther you find Options @brianteeman shows in "Before"-Screenshot
- apply Patch
- test if PR works as described.
I have tested this item
@icampus
I've testet this issue sucessfully. Everything works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.
I have tested this item
@icampus
I've testet this issue sucessfully. Everything works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.
thank you @franz-wohlkoenig for help
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-21 11:47:22 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks for testing and merging.
I have tested this item? unsuccessfully on 14a6c27
Fields aren't shown using PR:
System information
3.8-dev
Multilanguage Site
macOS Sierra, 10.12.6
Firefox 54 (64-bit)
MAMP 4.1.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17373.