?
avatar zero-24
zero-24
29 Jul 2017

Steps to reproduce the issue

http://213.160.72.75/joomla/joomla-cms/7422

Expected result

No errors

Actual result

6 tests failed

System information (as much as possible)

none

Additional comments

none

avatar zero-24 zero-24 - open - 29 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Jul 2017
avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

First part: #17341

Think drone needs restarting though as it seems to have stopped

avatar zero-24
zero-24 - comment - 29 Jul 2017

Think drone needs restarting though as it seems to have stopped

done

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

thanks, 5/6 fixed.

avatar zero-24 zero-24 - change - 29 Jul 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-07-29 19:16:39
Closed_By zero-24
avatar zero-24 zero-24 - close - 29 Jul 2017
avatar zero-24
zero-24 - comment - 29 Jul 2017

or should this be open until you could fix the last error?

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

yeah leave it open for the time being.

avatar zero-24 zero-24 - change - 29 Jul 2017
Status Closed New
Closed_Date 2017-07-29 19:16:39
Closed_By zero-24
avatar zero-24 zero-24 - reopen - 29 Jul 2017
avatar dgt41
dgt41 - comment - 29 Jul 2017

@C-Lodder do you want me to fix this?

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

If you could fix that last error, that would be great. I can't seem to figure out what the problem is.

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

Only thing that may work is .not.toContain('class');

avatar dgt41
dgt41 - comment - 29 Jul 2017

Line 42:

		it("should remove attribute class from icon", function() {
			expect($('#icon_0')).not.toHaveAttr('class', '');
		});

line 129:

			it("should remove attribute style from icon", function() {
				expect($('#icon_0')).not.toHaveAttr('class', '');
			});

screen shot 2017-07-29 at 23 04 35

EDIT Scrap that, just remove both these tests, the GSOC student will patch this properly

avatar C-Lodder
C-Lodder - comment - 29 Jul 2017

Done.

@zero-24 Drone tests passing now so you can close this issue

avatar zero-24
zero-24 - comment - 29 Jul 2017

Thanks!

avatar zero-24 zero-24 - change - 29 Jul 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-07-29 20:43:17
Closed_By zero-24
avatar zero-24 zero-24 - close - 29 Jul 2017

Add a Comment

Login with GitHub to post a comment