? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
29 Jul 2017

Pull Request for Issue #17223

Summary of Changes

Add the checked attribute for the bcc field

Testing Instructions

Pre patch the send bcc is not checked by default
after patch it is

Expected result

image

Actual result

image

Documentation Changes Required

None

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2017
Category Administration com_users
avatar zero-24 zero-24 - open - 29 Jul 2017
avatar zero-24 zero-24 - change - 29 Jul 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jul 2017
Easy No Yes
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

I have tested this item successfully on 49bedc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17336.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

please reassign Milestone 3.8.0

avatar brianteeman
brianteeman - comment - 29 Jul 2017

Doh I looked at this and didnt realise there was a checked value needed for a checkbox as it is nt mentioned in the documentation https://docs.joomla.org/Checkbox_form_field_type. Does it therefore still need the default value being set as well?

avatar zero-24
zero-24 - comment - 29 Jul 2017

I have just looked at the code and found the checked option. IMO we can change that in the doku than.

avatar zero-24
zero-24 - comment - 29 Jul 2017

or we have a very long stndig issue and need to fix the default value too.

avatar zero-24
zero-24 - comment - 29 Jul 2017

but that would be out of scope for that PR. IMO

avatar Quy Quy - test_item - 5 Aug 2017 - Tested successfully
avatar Quy
Quy - comment - 5 Aug 2017

I have tested this item successfully on 49bedc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17336.

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Aug 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Aug 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 5 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-05 15:11:08
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Aug 2017
avatar mbabker mbabker - merge - 5 Aug 2017

Add a Comment

Login with GitHub to post a comment