[#17312] - Update placeholder with module name from manifest.
- Closed
- 24 Oct 2017
- Medium
- Build: staging
- # 17312
- Diff
- bweston92:bugfix/module-installer-language
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
During a module install, when copying base files fails and exception is
thrown with a language definition. This language definition contains a
placeholder but is no replaced.
This commit will now make it replace the placeholder with the name from the
manifest.
The language definition is "JLIB_INSTALLER_ABORT_MOD_COPY_FILES"
The text at this time is "Module %s: Could not copy files from the
source."
Before:
After:
Given that the manifest has a name tag containing "mod_example"
<?xml version="1.0" encoding="utf-8"?>
<extension type="module" version="3.7.0" client="site" method="upgrade">
<name>mod_example</name>
</extension
Testing Instructions
Install a module with a files/folders that do not exist.
Expected result
The error to contain the extension name or remove the placeholder altogether.
Actual result
A placeholder in the error message on the Joomla! installation interface..
Documentation Changes Required
Not required.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@bweston92 can you give an Example of "Install a module with a files/folders that do not exist." for Test properly?
Just make one, I obviously made one by accident to notice it and it
shouldn't happen. The fact is it still happened and was an incorrect
message.
On Mon, 31 Jul 2017 at 13:20, Franz Wohlkönig notifications@github.com
wrote:
@bweston92 https://github.com/bweston92 can you give an Example of
"Install a module with a files/folders that do not exist." for Test
properly?—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
#17312 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrq2YC8jCsHwITozHKId9SG-IrPgWIIks5sTcZ7gaJpZM4Omahc
.
@bweston92 how to make one?
Can you look at resolving the conflicts so that this can be tested please.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-24 08:37:57 |
| Closed_By | ⇒ | bweston92 |
I have tested this item✅ successfully on b530da1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17312.