[#17303] - Simple change from str_ireplace to pref_replace for matching case sen…
- Fixed in Code Base
- 27 Jul 2017
- Medium
- Build: staging
- # 17303
- Diff
- tonypartridge:staging-search-title-case-sensitive
User tests: Successful: Unsuccessful:
Pull Request for Issue #17241
This stops the title replacements being replaced with the searched word and instead the actual word which is being replaced to be wrapped.
Summary of Changes
moved from str_ireplace
to preg_replace
Testing Instructions
Use joomla! com_search, search for a result which is is an uppercase with a lowercase letter i.e. Article is the title of the article search for article
Expected result
article and Article to be found but the hightlighted word to be case sensitive.
Actual result
The found match is replaced which the searched word.
joomla-cms-bot
- | Category | ⇒ | Front End com_search |
| Status | New | ⇒ | Pending |
@franz-wohlkoenig are you sure you applied the right patch?? Working on a fresh test here:
I have tested this item
fetched Data again > works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
| Labels |
Added:
?
|
||
Sorry @franz-wohlkoenig can you test again? :-) I've just added utf8/unicode support so we can use Arabic for example:
المستقبل
Many thanks
Tony
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-27 22:37:20 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item
One more for good measure
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
Awesome!
On 28 Jul 2017, 21:07 +0100, Nick Savov notifications@github.com, wrote:
I have tested this item
✅ successfully on fb7128eOne more for good measure
😃
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
I have tested this item🔴 unsuccessfully on eb31e8a
Searching for "Sample" (correct):
Searching for "sample" (not correct):
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17303.