? ? Pending

User tests: Successful: Unsuccessful:

avatar bweston92
bweston92
27 Jul 2017

As Joomla! provides a Docker image, the chance of using "localhost" is never. Therefore if the container is scheduled in an environment where you cannot access the container (not that you should ever need to) then you need to be able to bypass this check. This environment variable can be placed in the containers build file and will disable checks meaning you can install hassle free.

This check still keeps the installation secure as you'd need the same access to the server to delete the file.

Pull Request for Issue # joomla/docker-joomla#25.

Summary of Changes

Allow the check for localhost to be bypassed by an environment variable.

Testing Instructions

Set the environment variable JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK to one, attempt to install on a non localhost database server and no requirements to delete files should be shown.

Documentation Changes Required

This will need to go into the Joomla! docker build files, but may help to be documented somewhere.

There is a PR depending on this: joomla/docker-joomla#26

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2017
Category Installation
avatar bweston92 bweston92 - open - 27 Jul 2017
avatar bweston92 bweston92 - change - 27 Jul 2017
Status New Pending
avatar bweston92 bweston92 - change - 27 Jul 2017
The description was changed
avatar bweston92 bweston92 - edited - 27 Jul 2017
avatar bweston92 bweston92 - change - 27 Jul 2017
The description was changed
avatar bweston92 bweston92 - edited - 27 Jul 2017
avatar bweston92
bweston92 - comment - 27 Jul 2017

/ping @mbabker can you take a look at this as I seen you've created the Docker image.

avatar mbabker
mbabker - comment - 27 Jul 2017

From a practical perspective seems fine. @joomla/security review please.

avatar SniperSister
SniperSister - comment - 27 Jul 2017

Fine for me

avatar mbabker mbabker - change - 27 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-27 19:54:28
Closed_By mbabker
Labels Added: ? ?
avatar mbabker mbabker - close - 27 Jul 2017
avatar mbabker mbabker - merge - 27 Jul 2017

Add a Comment

Login with GitHub to post a comment