? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jul 2017

Pull Request for Issue #17142 .

Summary of Changes

Removes the options to force a menu item or login form to be http or https

We should not encourage this at all. A site should either be all http or all https - the options for this in glbal configuration remain

90b327a 26 Jul 2017 avatar brianteeman field
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2017
Category Administration com_menus Language & Strings Modules SQL Installation Postgresql Front End Unit Tests
avatar brianteeman brianteeman - open - 26 Jul 2017
avatar brianteeman brianteeman - change - 26 Jul 2017
Status New Pending
avatar brianteeman brianteeman - change - 26 Jul 2017
The description was changed
avatar brianteeman brianteeman - edited - 26 Jul 2017
avatar tonypartridge
tonypartridge - comment - 26 Jul 2017

Great @brianteeman , can you also remove the PHP Code using these settings?

avatar brianteeman
brianteeman - comment - 26 Jul 2017

@tonypartridge unless I misread the code (in which case please submit a PR against my branch) the code is used for the force site https option in global configuration

avatar tonypartridge
tonypartridge - comment - 26 Jul 2017

I shouldn't look at the code on my phone... I see you are removing them as we were setting them in the form from what I can see. All good, just fix drone ;-)

avatar brianteeman
brianteeman - comment - 26 Jul 2017

i think the drone issue is unrelated

avatar zero-24
zero-24 - comment - 26 Jul 2017

Drone is satisfied now.

avatar wilsonge wilsonge - change - 27 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-27 10:10:58
Closed_By wilsonge
Labels Added: ? ? ?
avatar wilsonge wilsonge - close - 27 Jul 2017
avatar wilsonge wilsonge - merge - 27 Jul 2017
avatar brianteeman
brianteeman - comment - 27 Jul 2017

Thanks - that was fast

Add a Comment

Login with GitHub to post a comment