? ?
avatar brianteeman
brianteeman
26 Jul 2017

As discussed with @mbabker we can permanently resolve the issue of the name of the installation folder from being translated by removing it from the string and inserting it dynamically using JText::sprintf

All other attempts have failed so this is the only way we can ensure that users are presented with the correct information

avatar brianteeman brianteeman - open - 26 Jul 2017
avatar infograf768
infograf768 - comment - 28 Jul 2017

Will that be B/C if a specific language installation ini file is not updated?
Looks like it will be for what concerns the suppression of the folder.

screen shot 2017-07-28 at 10 35 01

avatar mbabker
mbabker - comment - 28 Jul 2017

Will that be B/C if a specific language installation ini file is not updated?

Should be. JText::sprintf() is just a fancy wrapper around PHP's sprintf(), so if you have text with no placeholders within it then sprintf() just returns the same string with no changes.

avatar brianteeman
brianteeman - comment - 28 Jul 2017

Best thing to do if you are unsure is to test it

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Jul 2017
Category com_installer
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jul 2017
Status New Discussion
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2017
Category com_installer Installation Language & Strings
avatar brianteeman
brianteeman - comment - 7 Aug 2017

conflicts resolved

avatar brianteeman brianteeman - change - 7 Aug 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 7 Aug 2017

@mbabker I am a bit confused. I have the changes locally and I can see them in the commits 6bb185f

avatar mbabker
mbabker - comment - 7 Aug 2017

Apparently it got lost in your merge commit. c707073 - I can see the changes being undone there.

avatar brianteeman
brianteeman - comment - 7 Aug 2017

I guess I need to learn how to force the changes to be recomited

avatar brianteeman
brianteeman - comment - 7 Aug 2017

Easier for me to just do a new PR see #17436

avatar brianteeman brianteeman - change - 7 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-07 14:05:14
Closed_By brianteeman
avatar brianteeman brianteeman - close - 7 Aug 2017

Add a Comment

Login with GitHub to post a comment