[#17270] - mod_articles_category items no longer contain tag data
- Closed
- 28 Apr 2018
- Medium
- Build: staging
- # 17270
Steps to reproduce the issue
- Create a layout override for mod_articles_category
- Create a module that uses the layout override
- Within your layout, in the loop to output items, try to access
$item->tags
Expected result
The item tags are part of the item object and can be used in the layout.
Actual result
They're not. $item->tags is undefined and throws a PHP error
System information (as much as possible)
Joomla 3.7.4
Apache 2.4
PHP 5.6
Centos 7
Additional comments
This is a direct result of #16335. Any existing layouts that make use of tag data now throw errors as the helper file in all mod_articles_* modules calls $articles->setState('load_tags', false);, preventing tags from being loaded.
Proposed solution
Add an advanced option to each of the mod_articles_* modules to allows the user to decide if tags should be loaded, rather than hardcoding it on the assumption they won't be required.
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | com_modules com_tags |
| Status | New | ⇒ | Information Required |
Well, there's either two options here.
- Revert that PR's changes in the modules and always load tag data no matter what (trace back to the original issue report for why this can be problematic)
- If someone needs these modules with tag data loaded in they'll need to fork them
Perhaps a third way is a toggle as per the issue proposed solution? Call it 'Load Tags?', set to No by default (as I believe the only layouts using tags will be custom overrides) and allow power users / devs to pick.
Forking every mod_articles_* module, along with the associated hassle in keeping them in sync with updates to Joomla, just to comment out 1 line of code seems drastic.
| Status | Information Required | ⇒ | Discussion |
Just wondering if anyone has had any further thoughts on this - we're holding back on upgrading a few of our sites as they use tag data in a layout and the upgrade will break them, and I'm getting poked by Phil's robots at myJoomla to upgrade
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-28 11:02:44 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17270
@mbabker it was your PR that apparently broke this