?
avatar brianteeman
brianteeman
26 Jul 2017

This function needs reviewing now that we are not using styled tooltips/popovers in many places

For example in the permissions pages
screenshotr10-09-02

As a title tag can't parse html we dont need to present this with the code used at https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/cms/html/html.php#L942

The title tag should only be the description in this case and not as in the code above.

(I have not done a PR as I don't know if there any knock on effects elsewhere etc and the entire function probably needs a review)

avatar brianteeman brianteeman - open - 26 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Jul 2017
avatar dgt41
dgt41 - comment - 26 Jul 2017

@brianteeman 2 things here:

  • tooltips should not contain html mark up
  • tooltips should be css based and activated on click, touch!
avatar brianteeman
brianteeman - comment - 26 Jul 2017

tooltips should not contain html mark up

I know and that's why I am saying this

tooltips should be css based and activated on click, touch!

Not part of this issue (true but beyond the scope of what I am referring to - I would love us to use https://github.com/ghosh/microtip for that)

avatar dgt41
dgt41 - comment - 26 Jul 2017

AFAIK @ciar4n already showcased something similar, based on https://kazzkiq.github.io/balloon.css/

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Jul 2017
Category UI/UX
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Jul 2017
Status New Discussion
avatar infograf768
infograf768 - comment - 28 Jul 2017

The title tag should only be the description in this case and not as in the code above.

We may have issues in this case when the description is long (it also have to contain our existing labels) and needs LRs
How to deal with LR ?

avatar dgt41
dgt41 - comment - 28 Jul 2017

what is LR?

avatar infograf768
infograf768 - comment - 28 Jul 2017

Line Return

avatar infograf768
infograf768 - comment - 28 Jul 2017

<br> in html markup

avatar brianteeman
brianteeman - comment - 28 Jul 2017

No there wont be a problem as a title should not have any line breaks in it and we are using this in very few places now

avatar dgt41
dgt41 - comment - 28 Jul 2017

tooltips should never, ever have line returns, or be very long (few, really few words). Otherwise don't use tooltips use popover

avatar infograf768
infograf768 - comment - 28 Jul 2017

therefore it means that something like
screenshotr10-09-02

will need popovers

avatar dgt41
dgt41 - comment - 28 Jul 2017

this can be refactored so the actual title dosn't need expiation! It should be self explanatory. So let's fix the title and skip the tooltip all together there

avatar brianteeman
brianteeman - comment - 28 Jul 2017

There is no need for the title to be repeated in the title - therefore you dont need the html markup in there

avatar infograf768
infograf768 - comment - 28 Jul 2017

In this case, I strongly suggest you think twice about non-english languages as we have many places where descriptions/labels are twice as long as en-GB

avatar dgt41
dgt41 - comment - 28 Jul 2017

@brianteeman @infograf768 from accessibility and UX perspective tooltips and popover indicate a poor design, most of the times. so in the above example instead of some meaningless Configure ACL & Options let's have something that describes better the action (even if it's longer, we can figure out the design later)

avatar brianteeman
brianteeman - comment - 28 Jul 2017

In this case, I strongly suggest you think twice about non-english languages as we have many places where descriptions/labels are twice as long as en-GB

Not in J4 we dont

avatar brianteeman
brianteeman - comment - 28 Jul 2017

to be honest I am not even convinced that the string is even required in this example

avatar brianteeman brianteeman - change - 24 Mar 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-03-24 09:57:37
Closed_By brianteeman
avatar brianteeman brianteeman - close - 24 Mar 2018

Add a Comment

Login with GitHub to post a comment