? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
25 Jul 2017

Pull Request for Issue #17226

Summary of Changes

Adds an edit icon to the list items in com_languages as per the other components

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2017
Category Administration com_languages
avatar C-Lodder C-Lodder - open - 25 Jul 2017
avatar C-Lodder C-Lodder - change - 25 Jul 2017
Status New Pending
avatar brianteeman brianteeman - test_item - 25 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Jul 2017

I have tested this item successfully on 5e33563


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17242.

avatar C-Lodder C-Lodder - change - 25 Jul 2017
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

I have tested this item successfully on c4a48a6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17242.

avatar dgt41 dgt41 - change - 25 Jul 2017
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 25 Jul 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17242.

avatar C-Lodder
C-Lodder - comment - 25 Jul 2017

please wait. Just doing the rest of the components

avatar dgt41
dgt41 - comment - 25 Jul 2017

I won't remove the RTC, just ask @brianteeman to confirm when you're done ;)

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2017
Category Administration com_languages Administration com_fields com_languages com_menus com_redirect com_templates com_users
avatar C-Lodder C-Lodder - change - 25 Jul 2017
Labels Added: ?
avatar brianteeman brianteeman - test_item - 25 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Jul 2017

I have tested this item successfully on 6bac151

retested with the full list - all looks good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17242.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

Click on "Apply Patch" got:
bildschirmfoto 2017-07-25 um 15 27 10

avatar C-Lodder
C-Lodder - comment - 25 Jul 2017

@franz-wohlkoenig - Re-fetch the latest code from the repo before applying the PR. Another PR was merged whilst I was doing this which changed the file location.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

Reinstalled core Files per Joomla-Update + Fetched Data in Patch Tester, same Error-Message.

avatar C-Lodder
C-Lodder - comment - 25 Jul 2017

No idea then, sorry. I don't use the patch tester

avatar mbabker
mbabker - comment - 25 Jul 2017

If you're using the nightly builds those are going to be some commits behind until the next run (they are nightly builds after all, not generated on every commit to our dev branches).

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

@mbabker thanks, have forgotten one more Time this Difference. Is there a url like for nightly builds to update on Dev-Branche?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

thanks @brianteeman, using this url got:
bildschirmfoto 2017-07-25 um 15 56 32

avatar zero-24
zero-24 - comment - 25 Jul 2017

@franz-wohlkoenig you can not use that as update server ;) You need to download the link shared by brian and use upload and install ;)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Jul 2017

@zero-24 thanks for helping. After "Upload & Update" > "Upload & Install" zip-File and new "Fetch Data" in Patch Tester got same Message.

avatar C-Lodder C-Lodder - change - 25 Jul 2017
Title
[4.0] Add edit button to list views in com_languages
[4.0] Add edit button to remaining list views
avatar C-Lodder C-Lodder - edited - 25 Jul 2017
avatar wilsonge wilsonge - change - 26 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-26 14:01:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jul 2017
avatar wilsonge wilsonge - merge - 26 Jul 2017

Add a Comment

Login with GitHub to post a comment