Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17234] - Frontend: com_search view review

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Jul 2017

Summary of Changes

Frontend: com_search view review

Testing Instructions

Install testing data and test the frontend com_search

Expected result

works

Actual result

works, with cs issues

Documentation Changes Required

none

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2017
Category ⇒ Front End
avatar zero-24 zero-24 - open - 24 Jul 2017
avatar zero-24 zero-24 - change - 24 Jul 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2017
Category Front End ⇒ Front End com_search
avatar zero-24 zero-24 - change - 24 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2017
Category Front End com_search ⇒ Unit Tests Repository Administration com_admin SQL Postgresql MS SQL com_banners com_categories com_config com_contact
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2017
Category Unit Tests Repository Administration com_admin SQL Postgresql MS SQL com_banners com_categories com_config com_contact ⇒ Unit Tests Repository Administration com_admin SQL
avatar zero-24 zero-24 - change - 14 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2017
Category Unit Tests Repository Administration com_admin SQL ⇒ Front End com_search
avatar zero-24
zero-24 - comment - 17 Aug 2017

ok so finally i have fixed the merge conflicts here too.

avatar zero-24 zero-24 - change - 18 Aug 2017
Labels Removed: ?
avatar Quy Quy - test_item - 1 Sep 2017 - Tested successfully
avatar Quy
Quy - comment - 1 Sep 2017

I have tested this item ✅ successfully on 0cc0a8c

Code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17234.

avatar sanderpotjer sanderpotjer - test_item - 2 Sep 2017 - Tested unsuccessfully
avatar sanderpotjer
sanderpotjer - comment - 2 Sep 2017

I have tested this item 🔴 unsuccessfully on 0cc0a8c

After applying the patch the category is no longer visible in the search results:

Before:
screen shot 2017-09-02 at 11 15 36

After:
screen shot 2017-09-02 at 11 15 28

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17234.
avatar zero-24
zero-24 - comment - 2 Sep 2017

fixed with the last commit @sanderpotjer thanks 👍

avatar sanderpotjer sanderpotjer - test_item - 2 Sep 2017 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 2 Sep 2017

I have tested this item ✅ successfully on bf83d49

@zero-24 thanks for the fix, all good now!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17234.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Sep 2017

@Quy can you please retest?

avatar Quy Quy - test_item - 2 Sep 2017 - Tested successfully
avatar Quy
Quy - comment - 2 Sep 2017

I have tested this item ✅ successfully on bf83d49

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17234.

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Sep 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Sep 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 3 Sep 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-09-03 16:28:41
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Sep 2017
avatar mbabker mbabker - merge - 3 Sep 2017

Add a Comment

Login with GitHub to post a comment