[#17232] - Frontend: com_finder view review
- Fixed in Code Base
- 3 Sep 2017
- Medium
- Build: staging
- # 17232
- Diff
- zero-24:com_finder
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Frontend: com_finder view review
Testing Instructions
Test the com_finder search in the frontend
Expected result
Works
Actual result
Works, with cs issues
Documentation Changes Required
none
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
-
Smart Search is NOT indexed:
If I entered par example 'joomla' as a search term, there is the following message:
Warning: Invalid argument supplied for foreach() in ..\components\com_finder\views\search\tmpl\default_results.php on line 49. (NOK) -
After indexing, there is NO warning message. (OK)
- Joomla! 3.8.0-beta3-dev Development
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17232.
Warning: Invalid argument supplied for foreach() in ..\components\com_finder\views\search\tmpl\default_results.php on line 49.
@sandewt hmm. i have not changed that thing. Can you please double check that the same issue exists in staging and open a new issue where you describe how to reproduce that issue? Thanks.
I opened a new issue #17731.
After indexing, there is also a warning message if the search term is unkown (see above).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17232.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17232.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17232.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-03 16:26:18 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c5c2d8c
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17232.