[#17209] - Convert any special characters from 'Site Name' settled in Global Con…
- Fixed in Code Base
- 1 Sep 2017
- Medium
- Build: staging
- Easy Test
- # 17209
- Diff
- nppsbh:patch-3
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
…figuration
Example
Site name: my "website name"
HTML output
without this change:
<img src="/administrator/templates/isis/images/joomla.png" alt="my " website="" name""="">
with this change:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Status | New | ⇒ | Pending |
The change is correct when the site name is used in html.
Beware when $sitename is used for mails. In that case htmlspecialchars should not be used.
Please add some detailed test instructions
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209.
| Status | Pending | ⇒ | Information Required |
@Heggi93 pretty much as it says in the original post.
In global configuration create a site name with a special character eg My "site" Rocks
On the administrator login page view the source code for the joomla logo. Before this PR the alt text will be invalid markup. After this PR the alt text should be valid markup.
Note that if correct then this change needs to be used in other places that we use the $sitename variable in a similar way
I have tested this item
Source Code without PR:
Source Code with PR:
@brianteeman Thanks for Test Instructions.
@Heggi93 can you please test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209.
| Easy | No | ⇒ | Yes |
| Status | Information Required | ⇒ | Discussion |
| Status | Discussion | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17209.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-01 12:13:06 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Not checked this but surely if it correct them the change has to be made everywhere that we get the sitemap!e and not just in the login