? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Jul 2017

Merge by review once Travis passed.

avatar Bakual Bakual - open - 20 Jul 2017
avatar Bakual Bakual - change - 20 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2017
Category Installation Language & Strings
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jul 2017

Travis is passed.

avatar Bakual Bakual - change - 21 Jul 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 21 Jul 2017

I see that we are still accepting translations that are translating the name of the installation folder :(

Can we please not merge these obviously incorrect translations

avatar Bakual
Bakual - comment - 21 Jul 2017

I'm not going to play "translation police".

avatar brianteeman
brianteeman - comment - 21 Jul 2017

This is crazy - we have an obvious mistake in the translation - we should not be merging anything that is incorrect

avatar Bakual
Bakual - comment - 21 Jul 2017

The question is who is going to enforce that? I refuse to do that. I do check the technical correctness of the files to a degree, but not the content of the translation. That one is the responsibility of the translator.

Imho, the users of those languages should open a complain/issue with their respective translation teams. If they don't care, I will not care as well.

avatar brianteeman
brianteeman - comment - 21 Jul 2017

I guess it is time to take this seriously then and if you wont then we need someone who will ;(

avatar brianteeman
brianteeman - comment - 21 Jul 2017

I apologise for caring

avatar infograf768 infograf768 - change - 21 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-21 12:04:37
Closed_By infograf768
avatar infograf768 infograf768 - close - 21 Jul 2017
avatar infograf768 infograf768 - merge - 21 Jul 2017
avatar syntaxerror
syntaxerror - comment - 24 Jul 2017

It's the same "mistake" in the English files, using uppercase letters etc ...

If that "logic" of you @brianteeman should make any sense, it would need to be changed also in English. Because it's actually telling the exact same thing in English as it would in any other language when it's translated, for all those strings.

Like here it's also uppercase:
INSTL_COMPLETE_FOLDER_REMOVED="Installation folder removed."

To make your reasoning make any sense, it would need to be changed into something like:
INSTL_COMPLETE_FOLDER_REMOVED="The "installation" folder was removed."

Else there isn't anything more to waste time on, and pollute every language PR with, like a child trying to get his/her will this way ... Agree or disagree ...

avatar mbabker
mbabker - comment - 24 Jul 2017

@syntaxerror It's very obvious you have a dislike for Brian, there is no need to comment on every pull request arguing with him if you aren't going to add anything productive to the conversation.

avatar syntaxerror
syntaxerror - comment - 24 Jul 2017

Oh, it seems like it's Brian having to post and post on every PR ... And I added something productive here, for those who care about others opinions.

avatar mbabker
mbabker - comment - 24 Jul 2017

You were fine until you started with the personal shots at the end. Leave those out of your posts if you really feel compelled to reply.

And you may look at it like someone crying, but fact of the matter is Brian is one of the few contributors who is a native English (British type) speaker, so I would hope he is doing a level of QA checks and "being childish" for the sake of ensuring things are consistent and grammatically correct, the same way others do levels of QA checks for things like code style or efficient (or even correct) PHP/JavaScript code.

avatar syntaxerror
syntaxerror - comment - 24 Jul 2017

So then he's allowed to do as he like. Treat people, translators and others like s h i t - so they don't care to contribute. Well ... that says it all ...

avatar mbabker
mbabker - comment - 24 Jul 2017

No, he is not free to do as he likes. And I fail to see the issue with him pointing out that the translation teams are not following instructions and providing potentially incorrect translations. If that's really seen as whining, then realistically any level of QA is whining.

avatar syntaxerror
syntaxerror - comment - 24 Jul 2017

Still he does in PR after PR, forums, Twitter etc. Using a level of language others are not allowed to.

And yes, he's a native British English speaker, not a native in other languages. So it's at it best only potential mistakes, assumed mistakes. But still it's being nagged about in PR after PR, without being a good example fixing the real issues in English instead.

Pointing out is one thing, nagging is another.

avatar rdeutz
rdeutz - comment - 24 Jul 2017

If there is a problem make a PR or open an issue, enough said here

Add a Comment

Login with GitHub to post a comment